From: Jarkko Nikula <jhnikula@gmail.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v5 1/3] ARM: OMAP: Beagle: revision detection
Date: Thu, 19 Aug 2010 09:53:29 +0300 [thread overview]
Message-ID: <20100819095329.3c39a8a9.jhnikula@gmail.com> (raw)
In-Reply-To: <1282147013-508-1-git-send-email-robertcnelson@gmail.com>
On Wed, 18 Aug 2010 10:56:51 -0500
Robert Nelson <robertcnelson@gmail.com> wrote:
> + ret = gpio_request(171, "rev_id_0");
> + if (ret < 0)
> + goto fail0;
> +
> + ret = gpio_request(172, "rev_id_1");
> + if (ret < 0)
> + goto fail1;
> +
> + ret = gpio_request(173, "rev_id_2");
> + if (ret < 0)
> + goto fail2;
...
> +fail2:
> + gpio_free(173);
> +fail1:
> + gpio_free(172);
> +fail0:
> + gpio_free(171);
This must be:
+fail2:
+ gpio_free(172);
+fail1:
+ gpio_free(171);
+fail0:
Otherwise the set looks good to me.
--
Jarkko
next prev parent reply other threads:[~2010-08-19 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 15:56 [PATCH v5 1/3] ARM: OMAP: Beagle: revision detection Robert Nelson
2010-08-18 15:56 ` [PATCH v5 2/3] ARM: OMAP: Beagle: only Cx boards use pin 23 for write protect Robert Nelson
2010-08-18 15:56 ` [PATCH v5 3/3] ARM: OMAP: Beagle: no gpio_wp pin connection on xM Robert Nelson
2010-08-19 6:53 ` Jarkko Nikula [this message]
2010-08-20 2:33 ` [PATCH v5 1/3] ARM: OMAP: Beagle: revision detection Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819095329.3c39a8a9.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.