From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521Ab0HTDnQ (ORCPT ); Thu, 19 Aug 2010 23:43:16 -0400 Received: from dhruva1.ncra.tifr.res.in ([158.144.12.129]:52514 "EHLO dhruva1.ncra.tifr.res.in" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438Ab0HTDnO (ORCPT ); Thu, 19 Aug 2010 23:43:14 -0400 From: "Raju Rameshwar Uprade" To: Greg KH , Marek Vasut Cc: Raju Rameshwar Uprade , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, maxinbjohn@gmail.com, orest.bond@outpostembedded.com, vijaykumar@zilogic.com Subject: Re: Regarding USB-Serial Device driver Date: Fri, 20 Aug 2010 09:12:56 +0530 Message-Id: <20100820033259.M54157@admin-gateway.ncra.tifr.res.in> In-Reply-To: <20100819141812.GA12375@suse.de> References: <20100819055329.M29689@admin-gateway.ncra.tifr.res.in> <20100819061525.M24093@admin-gateway.ncra.tifr.res.in> <201008190938.44532.marek.vasut@gmail.com> <20100819141812.GA12375@suse.de> X-Mailer: OpenWebMail 2.53 (08:Aug:2008) X-OriginatingIP: 158.144.12.129 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg, No the driver is not working properly for me.I have connected RS-485 interface card to the USB-Serial adaptor through which I am controlling six MCM card( Control & Monitor unit). When I send command to MCM 2 , command also goes to MCM 10 & 0. When I checked on the oscilloscope, I found out that instead of going some ten bytes, large number of bytes are going out. Current kernel version have that RTS support, but for 2.6.25 it doesn't have. I am having confusion that form where so many bytes are going out. If you can help me out,I would be very thankful to you. Thanks, Raju. On Thu, 19 Aug 2010 07:18:12 -0700, Greg KH wrote > On Thu, Aug 19, 2010 at 09:38:44AM +0200, Marek Vasut wrote: > > Dne ??t 19. srpna 2010 08:17:30 Raju Rameshwar Uprade napsal(a): > > > Dear Sir, > > > I am trying to write a Pl2303_mcm.c usb-serial device driver which > > > will be able to talk to several devices using RS-485 interface card.I have > > > modified the standard pl2303.c by which I am able to enable/disable the > > > RTS line. > > > I am sending 10 bytes of data to the device, data is going out but instead > > > of 10 bytes, device driver is sending a large amount of data as seen on > > > Lecroy waverunner oscilloscope. Here I am sending the modified file. > > > > Hi, I have no idea why I'm CCed in this, but anyway. > > > > 1) could you please update the driver to a more recent kernel (we are 10 kernel > > versions further now) > > 2) could you please send a diff instead of a whole file? (git diff > > > diff.diff ... see man git-diff) > > Yes, Raju, please see the file, Documentation/SubmittingPatches for how > to do this properly. > > Also, does your updated driver work properly for you? It would be good > to have proper RTS support in the pl2303 driver, but I thought that the > driver already supported this? > > thanks, > > greg k-h -- Open WebMail Project (http://openwebmail.org)