From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43655 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnTpP-0002f5-FT
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:00:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OnTpI-0001I5-4J
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:00:25 -0400
Received: from mtagate2.de.ibm.com ([195.212.17.162]:37418)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OnTpH-0001Hc-SK
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:00:24 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com
	(d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id o7NA0Eqq011687
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 10:00:14 GMT
Received: from d12av03.megacenter.de.ibm.com (d12av03.megacenter.de.ibm.com
	[9.149.165.213])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o7NA0D054059170
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 12:00:13 +0200
Received: from d12av03.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av03.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o7NA0Dpj031339
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 12:00:13 +0200
Date: Mon, 23 Aug 2010 11:00:12 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 01/14] trace: Add trace-events file for
	declaring trace events
Message-ID: <20100823100012.GA2335@stefan-thinkpad.transitives.com>
References: <1281609395-17621-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1281609395-17621-2-git-send-email-stefanha@linux.vnet.ibm.com>
	<4C7198DC.9020501@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C7198DC.9020501@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Julien Desfossez <ju@klipix.org>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On Sun, Aug 22, 2010 at 04:38:36PM -0500, Anthony Liguori wrote:
> On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
> >+linetoh_nop()
> >+{
> >+    local name args
> >+    name=$(get_name "$1")
> >+    args=$(get_args "$1")
> >+
> >+    # Define an empty function for the trace event
> >+    cat<<EOF
> >+static inline void trace_$name($args)
> >+{
> >+}
> 
> This seems like it can potentially create a single header that ends
> up needed to know about every type of structure QEMU implements, no?
> If so, this would be challenging for improving modularity.
> 
> Or would we restrict trace points to not allow passing of anything
> but void *s?

Trace events use void *.  It would be nicer to use the specific struct
pointer type but that is not possible for the reason you mentioned.

Stefan