From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Nick Piggin <npiggin-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: Ryusuke Konishi
<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/6] nilfs2: remove own inode hash table
Date: Tue, 24 Aug 2010 04:30:28 -0400 [thread overview]
Message-ID: <20100824083027.GA27594@infradead.org> (raw)
In-Reply-To: <20100824074844.GH3948@amd>
On Tue, Aug 24, 2010 at 05:48:44PM +1000, Nick Piggin wrote:
> The reason I broke nilfs2 is because it duplicates a lot of the
> generic inode initialisation code. This really should go in core
> code because nilfs2 does not own the generic inode fields.
>
> It just needs some helper function to do the non-sb related init
> stuff for you.
No, the problem is much deeper than that. Having inodes outlive
superblock is fundamentally broken. All that crap simply needs
to go away.
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-24 8:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 10:05 [PATCH 0/6] nilfs2: remove own inode hash table Ryusuke Konishi
2010-08-22 10:05 ` [PATCH 3/6] nilfs2: keep zero value in i_cno except for gc-inodes Ryusuke Konishi
2010-08-22 10:05 ` [PATCH 5/6] nilfs2: separate initializer of metadata file inode Ryusuke Konishi
[not found] ` <1282471506-29618-1-git-send-email-konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2010-08-22 10:05 ` [PATCH 1/6] nilfs2: allow nilfs_destroy_inode to destroy metadata file inodes Ryusuke Konishi
2010-08-22 10:05 ` [PATCH 2/6] nilfs2: allow nilfs_dirty_inode to mark metadata file inodes dirty Ryusuke Konishi
2010-08-22 10:05 ` [PATCH 4/6] nilfs2: use iget5_locked to get inode Ryusuke Konishi
2010-08-22 10:05 ` [PATCH 6/6] nilfs2: remove own inode hash used for GC Ryusuke Konishi
2010-08-24 7:48 ` [PATCH 0/6] nilfs2: remove own inode hash table Nick Piggin
2010-08-24 8:30 ` Christoph Hellwig [this message]
[not found] ` <20100824083027.GA27594-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-08-24 12:58 ` Ryusuke Konishi
[not found] ` <20100824.215823.121933465.ryusuke-sG5X7nlA6pw@public.gmane.org>
2010-08-24 15:32 ` Christoph Hellwig
[not found] ` <20100824153214.GA25897-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-08-24 16:20 ` Ryusuke Konishi
[not found] ` <20100825.012012.179486471.ryusuke-sG5X7nlA6pw@public.gmane.org>
2010-08-24 16:42 ` Al Viro
2010-08-24 17:00 ` Ryusuke Konishi
2010-08-24 12:19 ` Ryusuke Konishi
2010-08-24 12:58 ` Nick Piggin
2010-08-24 13:24 ` Al Viro
[not found] ` <20100824132453.GU31363-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2010-08-24 15:39 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824083027.GA27594@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=npiggin-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.