From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760Ab0HXAeF (ORCPT ); Mon, 23 Aug 2010 20:34:05 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:60058 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445Ab0HXAeC (ORCPT ); Mon, 23 Aug 2010 20:34:02 -0400 Date: Tue, 24 Aug 2010 09:19:22 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: Daisuke Nishimura , linux-mm@kvack.org, "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , kamezawa.hiroyuki@gmail.com Subject: Re: [PATCH 4/5] memcg: lockless update of file_mapped Message-Id: <20100824091922.ae133d72.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20100824084916.078d6a82.kamezawa.hiroyu@jp.fujitsu.com> References: <20100820185552.426ff12e.kamezawa.hiroyu@jp.fujitsu.com> <20100820190256.531af759.kamezawa.hiroyu@jp.fujitsu.com> <20100823175015.8d834645.nishimura@mxp.nes.nec.co.jp> <20100824084916.078d6a82.kamezawa.hiroyu@jp.fujitsu.com> X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2010 08:49:16 +0900 KAMEZAWA Hiroyuki wrote: > On Mon, 23 Aug 2010 17:50:15 +0900 > Daisuke Nishimura wrote: > > > This patch looks good to me, but I have one question. > > > > Why do we need to acquire sc.lock inside mem_cgroup_(start|end)_move() ? > > These functions doesn't access mc.*. > > > > just reusing a lock to update status. If you don't like, I'll add a new lock. > I see. I think it would be enough just to add some comments about it. Thanks, Daisuke Nishimura. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 405EA6B03F1 for ; Mon, 23 Aug 2010 20:33:48 -0400 (EDT) Date: Tue, 24 Aug 2010 09:19:22 +0900 From: Daisuke Nishimura Subject: Re: [PATCH 4/5] memcg: lockless update of file_mapped Message-Id: <20100824091922.ae133d72.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20100824084916.078d6a82.kamezawa.hiroyu@jp.fujitsu.com> References: <20100820185552.426ff12e.kamezawa.hiroyu@jp.fujitsu.com> <20100820190256.531af759.kamezawa.hiroyu@jp.fujitsu.com> <20100823175015.8d834645.nishimura@mxp.nes.nec.co.jp> <20100824084916.078d6a82.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Daisuke Nishimura , linux-mm@kvack.org, "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , kamezawa.hiroyuki@gmail.com List-ID: On Tue, 24 Aug 2010 08:49:16 +0900 KAMEZAWA Hiroyuki wrote: > On Mon, 23 Aug 2010 17:50:15 +0900 > Daisuke Nishimura wrote: > > > This patch looks good to me, but I have one question. > > > > Why do we need to acquire sc.lock inside mem_cgroup_(start|end)_move() ? > > These functions doesn't access mc.*. > > > > just reusing a lock to update status. If you don't like, I'll add a new lock. > I see. I think it would be enough just to add some comments about it. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org