[PATCH] xenpaging: call pageout policy function in xenpaging_evict_page

[PATCH] xenpaging: call pageout policy function in xenpaging_evict_page

[Olaf Hering]

Notify policy about a page that was just paged out to disk.
Up to now the code called the opposite function, which clears the
(xenpaging internal) reference bit, instead of setting it and marking
the page as gone.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

--- xen-unstable.hg-4.1.21976.orig/tools/xenpaging/xenpaging.c
+++ xen-unstable.hg-4.1.21976/tools/xenpaging/xenpaging.c
@@ -361,8 +361,8 @@ int xenpaging_evict_page(xc_interface *x
         goto out;
     }
 
-    /* Notify policy of page being paged in */
-    policy_notify_paged_in(paging->mem_event.domain_id, victim->gfn);
+    /* Notify policy of page being paged out */
+    policy_notify_paged_out(paging->mem_event.domain_id, victim->gfn);
 
  out:
     return ret;

Re: [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page

[Ian Jackson]

Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):
> Notify policy about a page that was just paged out to disk.
> Up to now the code called the opposite function, which clears the
> (xenpaging internal) reference bit, instead of setting it and marking
> the page as gone.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

This looks plausible but as I don't really understand the xenpaging
code I'd like an ack from Patrick.  Patrick ?

Thanks,
Ian.

Re: [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page

[Patrick Colp]

Yes, this patch is correct.

Acked-by: Patrick Colp <pjcolp@cs.ubc.ca>


Patrick


On 24 August 2010 10:05, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):
>> Notify policy about a page that was just paged out to disk.
>> Up to now the code called the opposite function, which clears the
>> (xenpaging internal) reference bit, instead of setting it and marking
>> the page as gone.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> This looks plausible but as I don't really understand the xenpaging
> code I'd like an ack from Patrick.  Patrick ?
>
> Thanks,
> Ian.
>
>