From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: [PATCH kvm-unit-tests 08/10] Check whether in long mode before testing vmexit caused by cr8 access Date: Tue, 24 Aug 2010 21:47:51 +0800 Message-ID: <20100824134751.17082.29122.stgit@FreeLancer> References: <20100824134523.17082.8727.stgit@FreeLancer> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: jasowang@redhat.com, mtosatti@redhat.com, avi@redhat.com, kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29155 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755237Ab0HXNrx (ORCPT ); Tue, 24 Aug 2010 09:47:53 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7ODlrqM025823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Aug 2010 09:47:53 -0400 In-Reply-To: <20100824134523.17082.8727.stgit@FreeLancer> Sender: kvm-owner@vger.kernel.org List-ID: CR8 is only availabe when in long mode. Signed-off-by: Jason Wang --- x86/vmexit.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/x86/vmexit.c b/x86/vmexit.c index 819c24b..34b0af4 100644 --- a/x86/vmexit.c +++ b/x86/vmexit.c @@ -48,6 +48,7 @@ static void vmcall(void) #define MSR_EFER 0xc0000080 #define EFER_NX_MASK (1ull << 11) +#define EFER_LMA_MASK (1ull << 10) static void mov_from_cr8(void) { @@ -68,6 +69,15 @@ static int is_smp(void) return cpu_count() > 1; } +static int is_long_mode(void) +{ +#ifdef __i386__ + return 0; +#else + return rdmsr(MSR_EFER) | EFER_LMA_MASK; +#endif +} + static void nop(void *junk) { } @@ -100,8 +110,8 @@ static struct test { } tests[] = { { cpuid_test, "cpuid", .parallel = 1, }, { vmcall, "vmcall", .parallel = 1, }, - { mov_from_cr8, "mov_from_cr8", .parallel = 1, }, - { mov_to_cr8, "mov_to_cr8" , .parallel = 1, }, + { mov_from_cr8, "mov_from_cr8", is_long_mode, .parallel = 1, }, + { mov_to_cr8, "mov_to_cr8" , is_long_mode, .parallel = 1, }, { inl_pmtimer, "inl_from_pmtimer", .parallel = 1, }, { ipi, "ipi", is_smp, .parallel = 0, }, { ipi_halt, "ipi+halt", is_smp, .parallel = 0, },