From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 14/14] drm: kill agp indirection mess
Date: Tue, 24 Aug 2010 18:20:00 +0200
Message-ID: <20100824161959.GA3466@viiv.ffwll.ch>
References: <1282596816-10896-1-git-send-email-daniel.vetter@ffwll.ch>
	<1282596816-10896-15-git-send-email-daniel.vetter@ffwll.ch>
	<AANLkTinECi6ZMO3fPfkXdRFWDcW0kcaVZ9DOZU38mN8d@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail.ffwll.ch (cable-static-49-187.intergga.ch [157.161.49.187])
	by gabe.freedesktop.org (Postfix) with ESMTP id 83FE39E733
	for <dri-devel@lists.freedesktop.org>;
	Tue, 24 Aug 2010 09:18:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <AANLkTinECi6ZMO3fPfkXdRFWDcW0kcaVZ9DOZU38mN8d@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Kristian =?iso-8859-1?Q?H=F8gsberg?= <krh@bitplanet.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Tue, Aug 24, 2010 at 11:05:04AM -0400, Kristian H=F8gsberg wrote:
> > =A0/** Wrapper around agp_unbind_memory() */
> > =A0int drm_unbind_agp(DRM_AGP_MEM * handle)
> > =A0{
> > - =A0 =A0 =A0 return drm_agp_unbind_memory(handle);
> > + =A0 =A0 =A0 return agp_unbind_memory(handle);
> > =A0}
> > =A0EXPORT_SYMBOL(drm_unbind_agp);
> =

> Any reason to keep these last three wrappers around?

That would amount to completely ripping out the drm agp abstraction
(including DRM_AGP_MEM #defines and friends). A decently-sized patch
series touching lots of drivers, drm core (for the generic mapping stuff)
and the innards of ttm/gem.

But yeah, if people want this I can certainly prep patches. There's
already

#define DRM_AGP_MEM		struct agp_memory
#define DRM_AGP_KERN		struct agp_kern_info

so the whole thing can be accomplished without a flag day.

> Kristian

Cheers, Daniel

-- =

Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48