From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755318Ab0HXTbD (ORCPT ); Tue, 24 Aug 2010 15:31:03 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:36096 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717Ab0HXTbA (ORCPT ); Tue, 24 Aug 2010 15:31:00 -0400 Date: Tue, 24 Aug 2010 21:30:39 +0200 From: Ingo Molnar To: Randy Dunlap Cc: Mauro Carvalho Chehab , Linus Torvalds , Andrew Morton , Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency Message-ID: <20100824193039.GA20425@elte.hu> References: <4C643A08.3000605@redhat.com> <20100824084528.GA26618@elte.hu> <4C73E46B.8050203@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C73E46B.8050203@oracle.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Randy Dunlap wrote: > On 08/24/10 01:45, Ingo Molnar wrote: > > > > * Mauro Carvalho Chehab wrote: > > > >> Linus, > >> > >> Please pull from: > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > >> > >> For 3 build fixes. > >> > >> Cheers, > >> Mauro. > >> > >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > >> > >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) > >> > >> are available in the git repository at: > >> > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > >> > >> Mauro Carvalho Chehab (2): > >> V4L/DVB: Fix IR_CORE dependencies > >> V4L/DVB: fix Kconfig to depends on VIDEO_IR > >> > >> Randy Dunlap (1): > >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > > > FYI, there's one more IR_CORE related build bug which triggers > > frequently in randconfig tests - see the fix below. > > > > Thanks, > > > > Ingo > > > > -------------------> > > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar > > Date: Tue, 24 Aug 2010 10:41:33 +0200 > > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > > > This build bug triggers: > > > > drivers/built-in.o: In function `mantis_exit': > > (.text+0x377413): undefined reference to `ir_input_unregister' > > drivers/built-in.o: In function `mantis_input_init': > > (.text+0x3774ff): undefined reference to `__ir_input_register' > > > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > > dependency. > > > > Signed-off-by: Ingo Molnar > > --- > > drivers/media/dvb/mantis/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig > > index decdeda..fd0830e 100644 > > --- a/drivers/media/dvb/mantis/Kconfig > > +++ b/drivers/media/dvb/mantis/Kconfig > > @@ -1,6 +1,6 @@ > > config MANTIS_CORE > > tristate "Mantis/Hopper PCI bridge based devices" > > - depends on PCI && I2C && INPUT > > + depends on PCI && I2C && INPUT && IR_CORE > > > > help > > Support for PCI cards based on the Mantis and Hopper PCi bridge. > > > Acked-by: Randy Dunlap > http://lkml.org/lkml/2010/8/17/341 Your patch came first :-) Btw., the reason i missed your patch is that i grepped lkml for the static build failure - while your changelog contained the modular one. Oh well :) Thanks, Ingo