From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957Ab0HXVKk (ORCPT ); Tue, 24 Aug 2010 17:10:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40276 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755637Ab0HXVKi (ORCPT ); Tue, 24 Aug 2010 17:10:38 -0400 Date: Tue, 24 Aug 2010 14:10:16 -0700 From: Greg KH To: Samo Pogacnik Cc: linux kernel , linux-embedded , Alan Cox Subject: Re: [PATCH] detour TTY driver - now ttyprintk Message-ID: <20100824211016.GA7176@suse.de> References: <1275175983.2122.42.camel@itpsd6lap> <1276123020.16010.97.camel@itpsd6lap> <20100611134455.3fa7d563@lxorguk.ukuu.org.uk> <1276291932.2154.45.camel@itpsd6lap> <20100621153858.444695c0@lxorguk.ukuu.org.uk> <1277244410.2195.47.camel@itpsd6lap> <20100622232108.26752ff8@lxorguk.ukuu.org.uk> <1277462596.2143.101.camel@itpsd6lap> <20100625120329.1303aa61@lxorguk.ukuu.org.uk> <1282683470.8020.66.camel@itpsd6lap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282683470.8020.66.camel@itpsd6lap> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2010 at 10:57:50PM +0200, Samo Pogacnik wrote: > On 25.06.2010 (Fri) at 12:03 +0100 Alan Cox wrote: > > With my devices.txt owner hat on I'll allocate the minor as you suggest > > (and double check this causes no problems), with my tty hat on can you > > send it to GregKH for merging into the tree. > > Hi, > > I hope that this TTY driver is ok for merging. It is very basic - > removed all flow control and rate limiting. Patch has been generated > against 2.6.34 kernel version. > > Ttyprintk is a pseudo TTY driver, which allows users to make printk messages, > via output to ttyprintk device. It is possible to store "console" messages > inline with kernel messages for better analyses of the boot process, for > example. Why does this need to be a tty driver? Why not a misc device? And what about the normal way of just writing to /dev/kmsg to do this? Why a whole new driver for this same functionality? confused, greg k-h