From: Daniel Kiper <dkiper@net-space.pl>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Daniel Kiper <dkiper@net-space.pl>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, apic: Fix apic=debug boot crash
Date: Tue, 24 Aug 2010 23:39:31 +0200 [thread overview]
Message-ID: <20100824213931.GA1192@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <4C72B6F7.8010706@kernel.org>
Hello,
On 08/23/2010 07:54 AM, H. Peter Anvin wrote:
> It's already applied.
Thx.
On Mon, Aug 23, 2010 at 10:59:19AM -0700, Yinghai Lu wrote:
[...]
> >>>> x86, apic: Fix apic=debug boot crash
> >>>>
> >>>> Fix a boot crash when apic=debug is used and the APIC is
> >>>> not properly initialized.
> >>>>
> >>>> This issue appears during Xen Dom0 kernel boot but the
> >>>> fix is generic and the crash could occur on real hardware
> >>>> as well.
> >>>
> >>> Do you have any report on real hardware?
> >>> that could not happen on real hardware.
> >>
> >> Till now no, however I think it is good idea
> >> to apply this patch now. It is not worth to wait
> >> for another null pointer dereference.
>
> no, we should add BUG_ON() etc debug info there to see why that null cfg could happen.
> because according to code, we should have null there.
I think that BUG_ON() is too strong here because
it is "debug" function and it should work also
with let's say "invalid" data (in Xen case it is
normal because APIC state is managed directly
by hypervisor).
Additionally, with this patch it is easy to
differentiate between cfg != NULL and
cfg == NULL. Please look below:
cfg != NULL:
IRQ to pin mappings:
IRQ0 -> 0:2
IRQ1 -> 0:1
IRQ3 -> 0:3
IRQ4 -> 0:4
IRQ5 -> 0:5
IRQ6 -> 0:6
IRQ7 -> 0:7
IRQ8 -> 0:8
IRQ9 -> 0:9
IRQ10 -> 0:10
IRQ11 -> 0:11
IRQ12 -> 0:12
IRQ13 -> 0:13
IRQ14 -> 0:14
IRQ15 -> 0:15
.................................... done.
cfg == NULL:
IRQ to pin mappings:
.................................... done.
If I missed something or if you have any
questions please drop me a line.
Daniel
next prev parent reply other threads:[~2010-08-24 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 22:46 [PATCH] arch/x86/kernel/apic/io_apic.c: Fix for crash when apic=debug is used Daniel Kiper
2010-08-19 22:46 ` Daniel Kiper
2010-08-20 12:41 ` [tip:x86/urgent] x86, apic: Fix apic=debug boot crash tip-bot for Daniel Kiper
2010-08-20 19:24 ` Yinghai Lu
2010-08-23 8:12 ` Daniel Kiper
2010-08-23 14:54 ` H. Peter Anvin
2010-08-23 17:59 ` Yinghai Lu
2010-08-24 21:39 ` Daniel Kiper [this message]
2010-08-24 21:47 ` Yinghai Lu
2010-08-25 13:51 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824213931.GA1192@router-fw-old.local.net-space.pl \
--to=dkiper@net-space.pl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.