All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: Add generic driver for simple memory mapped controllers
Date: Thu, 26 Aug 2010 19:38:50 +0100	[thread overview]
Message-ID: <20100826183850.GB24381@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20100825194249.GA453@oksana.dev.rtsoft.ru>

On Wed, Aug 25, 2010 at 11:42:49PM +0400, Anton Vorontsov wrote:

> +	res_dat = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res_dat)
> +		return -EINVAL;

I'd suggest naming these resources rather than grabbing by number,
that'll make it easier to plumb the machine driver side in since you
don't have to remember which number corresponds to which function.

      parent reply	other threads:[~2010-08-26 18:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 19:42 [PATCH] gpio: Add generic driver for simple memory mapped controllers Anton Vorontsov
     [not found] ` <921098.64431.qm@web180306.mail.gq1.yahoo.com>
2010-08-26  5:17   ` Anton Vorontsov
2010-08-26 16:22     ` David Brownell
2010-08-26 16:48       ` Alan Cox
2010-08-26 17:34         ` David Brownell
2010-08-26 18:36           ` Mark Brown
2010-08-26 21:07           ` Alan Cox
2010-08-26 22:58             ` David Brownell
2010-08-27  0:15               ` Alan Cox
2010-08-26 17:26       ` [PATCH v2] gpio: Add driver for Anton GPIO controllers Anton Vorontsov
2010-08-26 17:57         ` David Brownell
2010-08-26 21:20           ` Anton Vorontsov
2010-08-26 22:48             ` David Brownell
2010-08-27 15:57               ` [PATCH v3] gpio: Add driver for basic memory-mapped " Anton Vorontsov
2010-08-28 19:08                 ` David Brownell
2010-08-29 21:28                   ` [PATCH v4] " Anton Vorontsov
2010-08-30 20:23                     ` David Brownell
2010-08-31 17:58                       ` [PATCH v5] " Anton Vorontsov
2010-08-31 18:21                         ` Mark Brown
2010-08-31 20:32                         ` David Brownell
2010-09-01 19:52                           ` [PATCH v6] " Anton Vorontsov
2010-09-07 14:01                           ` [PATCH v7] " Anton Vorontsov
2010-09-21 22:23                             ` Anton Vorontsov
2010-09-24 21:45                             ` Andrew Morton
2010-09-28 12:40                               ` [PATCH v7-fix] gpio: Add driver for basic memory-mapped GPIO controllers (fix) Anton Vorontsov
2010-08-26 18:38 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826183850.GB24381@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=akpm@linux-foundation.org \
    --cc=cbouatmailru@gmail.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.