All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>,
	Seungwhan Youn <claude.youn@gmail.com>,
	Seungwhan Youn <sw.youn@samsung.com>
Subject: Re: [PATCH 4/7] ASoC: Automatically calculate clock	ratio for WM8580
Date: Tue, 31 Aug 2010 11:42:32 +0100	[thread overview]
Message-ID: <20100831104232.GB31948@sirena.org.uk> (raw)
In-Reply-To: <AANLkTimG-LqfTG1x++uME1DaAAysgqS=5zwjHE_o0hsR@mail.gmail.com>

On Tue, Aug 31, 2010 at 03:46:44PM +0900, Jassi Brar wrote:

> Ok, now that I am faced with supporting latest SMDKs that use codecs
> other than WM8580 (like wm8994), I think we'd better break the MACHINE
> driver into SMDK specific (setup CPU master, CODEC slave and
> root-clock sourced acc to option provided vai platform_data)
> and CODEC specific part.
> That will also help code reuse.

> Any opinions, before I start working on it?

If you're looking at this it'd be a good idea to look at pulling the
clocking configuration for the CPU into the CPU driver - the Samsung
CPU hardware is fairly straightforward and easy to use and it should be
possible to automate much more of the configuration, at least by
default.  At the minute there's a lot of cut'n'paste code for the
clocking configuration which could do with being shared.

In terms of the stuff that is genuinely board specific I'd need to look
at the designs and discuss the use cases with you to really comment in
too much detail.  The WM8994 is a vastly more flexible part and there's
a number of interesting things you can do with it that might result in a
noticably different clocking configuration from the machine driver,
especially around things like the analogue bypass cases and keeping the
the device active during suspend, but a lot of this depends on the
system design as a whole.

  reply	other threads:[~2010-08-31 10:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 19:33 [PATCH 0/7] WM8580 updates Mark Brown
2010-08-13 19:35 ` [PATCH 1/7] ASoC: Add a bit of resource unwinding in the S3C IISv4 driver Mark Brown
2010-08-13 19:35 ` [PATCH 2/7] ASoC: Convert WM8580 hw_params to use snd_soc_update_bits() Mark Brown
2010-08-13 19:35 ` [PATCH 3/7] ASoC: Remove unused rate selection bitmasks from WM8580 Mark Brown
2010-08-13 19:35 ` [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580 Mark Brown
2010-08-15  9:00   ` Seungwhan Youn
2010-08-15 11:09     ` Mark Brown
2010-08-16  4:36       ` Jassi Brar
2010-08-16 10:20         ` Mark Brown
2010-08-16 12:51           ` Jassi Brar
2010-08-16 15:19             ` Mark Brown
2010-08-16 23:14               ` Jassi Brar
2010-08-17  9:46                 ` Mark Brown
2010-08-31  6:46                   ` Jassi Brar
2010-08-31 10:42                     ` Mark Brown [this message]
2010-08-16  4:16   ` Seungwhan Youn
2010-08-16 12:21     ` Mark Brown
2010-08-16 12:47       ` Jassi Brar
2010-08-13 19:35 ` [PATCH 5/7] ASoC: Implement BCLK rate selection " Mark Brown
2010-08-13 19:35 ` [PATCH 6/7] ASoC: Fix inverted WM8580 capture mute control Mark Brown
2010-08-15  4:50   ` Seungwhan Youn
2010-08-15  6:20     ` Seungwhan Youn
2010-08-13 19:35 ` [PATCH 7/7] ASoC: Automatically manage WM8580 DAC OSR Mark Brown
2010-08-14  4:09 ` [PATCH 0/7] WM8580 updates Jassi Brar
2010-08-15  9:21   ` Seungwhan Youn
2010-08-15 11:10     ` Mark Brown
2010-08-16  9:44       ` Seungwhan Youn
2010-08-16 14:49         ` Mark Brown
2010-08-19 11:37           ` Seungwhan Youn
2010-08-14 10:45 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831104232.GB31948@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=claude.youn@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=sw.youn@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.