From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030Ab0IAR7u (ORCPT ); Wed, 1 Sep 2010 13:59:50 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58785 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940Ab0IAR7k (ORCPT ); Wed, 1 Sep 2010 13:59:40 -0400 Date: Wed, 01 Sep 2010 10:59:55 -0700 (PDT) Message-Id: <20100901.105955.176668287.davem@davemloft.net> To: wg@grandegger.com Cc: w.sang@pengutronix.de, julia@diku.dk, kernel-janitors@vger.kernel.org, grant.likely@secretlab.ca, socketcan-core@lists.berlios.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak From: David Miller In-Reply-To: <4C7D565F.307@grandegger.com> References: <20100831191014.GA9603@pengutronix.de> <4C7D565F.307@grandegger.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wolfgang Grandegger Date: Tue, 31 Aug 2010 21:22:07 +0200 > On 08/31/2010 09:10 PM, Wolfram Sang wrote: >> On Tue, Aug 31, 2010 at 07:44:00PM +0200, Julia Lawall wrote: >>> Add a call to of_node_put in the error handling code following a call to >>> of_find_matching_node. >>> >>> This patch also moves the existing call to of_node_put after the call to >>> iounmap in the error handling code, to make it possible to jump to >>> of_node_put without doing iounmap. These appear to be disjoint operations, >>> so the ordering doesn't matter. >>> >>> This patch furthermore changes the -ENODEV result in the error handling >>> code for of_find_matching_node to a return of 0, as found in the error >>> handling code for of_iomap, because the return type of the function is >>> unsigned. >>> >>> The semantic match that finds this problem is as follows: >>> (http://coccinelle.lip6.fr/) ... >>> Signed-off-by: Julia Lawall >> >> Reviewed-by: Wolfram Sang > > Acked-by: Wolfgang Grandegger Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Date: Wed, 01 Sep 2010 10:59:55 -0700 (PDT) Message-ID: <20100901.105955.176668287.davem@davemloft.net> References: <20100831191014.GA9603@pengutronix.de> <4C7D565F.307@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, julia-dAYI7NvHqcQ@public.gmane.org To: wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org Return-path: In-Reply-To: <4C7D565F.307-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org From: Wolfgang Grandegger Date: Tue, 31 Aug 2010 21:22:07 +0200 > On 08/31/2010 09:10 PM, Wolfram Sang wrote: >> On Tue, Aug 31, 2010 at 07:44:00PM +0200, Julia Lawall wrote: >>> Add a call to of_node_put in the error handling code following a call to >>> of_find_matching_node. >>> >>> This patch also moves the existing call to of_node_put after the call to >>> iounmap in the error handling code, to make it possible to jump to >>> of_node_put without doing iounmap. These appear to be disjoint operations, >>> so the ordering doesn't matter. >>> >>> This patch furthermore changes the -ENODEV result in the error handling >>> code for of_find_matching_node to a return of 0, as found in the error >>> handling code for of_iomap, because the return type of the function is >>> unsigned. >>> >>> The semantic match that finds this problem is as follows: >>> (http://coccinelle.lip6.fr/) ... >>> Signed-off-by: Julia Lawall >> >> Reviewed-by: Wolfram Sang > > Acked-by: Wolfgang Grandegger Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 01 Sep 2010 17:59:55 +0000 Subject: Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add Message-Id: <20100901.105955.176668287.davem@davemloft.net> List-Id: References: <20100831191014.GA9603@pengutronix.de> <4C7D565F.307@grandegger.com> In-Reply-To: <4C7D565F.307-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, julia-dAYI7NvHqcQ@public.gmane.org From: Wolfgang Grandegger Date: Tue, 31 Aug 2010 21:22:07 +0200 > On 08/31/2010 09:10 PM, Wolfram Sang wrote: >> On Tue, Aug 31, 2010 at 07:44:00PM +0200, Julia Lawall wrote: >>> Add a call to of_node_put in the error handling code following a call to >>> of_find_matching_node. >>> >>> This patch also moves the existing call to of_node_put after the call to >>> iounmap in the error handling code, to make it possible to jump to >>> of_node_put without doing iounmap. These appear to be disjoint operations, >>> so the ordering doesn't matter. >>> >>> This patch furthermore changes the -ENODEV result in the error handling >>> code for of_find_matching_node to a return of 0, as found in the error >>> handling code for of_iomap, because the return type of the function is >>> unsigned. >>> >>> The semantic match that finds this problem is as follows: >>> (http://coccinelle.lip6.fr/) ... >>> Signed-off-by: Julia Lawall >> >> Reviewed-by: Wolfram Sang > > Acked-by: Wolfgang Grandegger Applied.