From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h Date: Wed, 1 Sep 2010 13:39:05 +0300 Message-ID: <20100901103905.GB7513@redhat.com> References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> <1283007298-10942-2-git-send-email-eduard.munteanu@linux360.ro> <20100831202953.GF31570@redhat.com> <20100831225830.GA10567@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: joro@8bytes.org, blauwirbel@gmail.com, paul@codesourcery.com, avi@redhat.com, anthony@codemonkey.ws, av1474@comtv.ru, yamahata@valinux.co.jp, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Eduard - Gabriel Munteanu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1027 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379Ab0IAKp2 (ORCPT ); Wed, 1 Sep 2010 06:45:28 -0400 Content-Disposition: inline In-Reply-To: <20100831225830.GA10567@localhost> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Sep 01, 2010 at 01:58:30AM +0300, Eduard - Gabriel Munteanu wrote: > On Tue, Aug 31, 2010 at 11:29:53PM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 28, 2010 at 05:54:52PM +0300, Eduard - Gabriel Munteanu wrote: > > > The conversion was done using the GNU 'expand' tool (default settings) > > > to make it obey the QEMU coding style. > > > > > > Signed-off-by: Eduard - Gabriel Munteanu > > > > I'm not really interested in this: we copied pci_regs.h from linux > > to help non-linux hosts, and keeping the code consistent > > with the original makes detecting bugs and adding new stuff > > from linux/pci_regs.h easier. > > > > > --- > > > hw/pci_regs.h | 1330 ++++++++++++++++++++++++++++---------------------------- > > > 1 files changed, 665 insertions(+), 665 deletions(-) > > > rewrite hw/pci_regs.h (90%) > > Ok, I'll drop it. The only reason I did it was one of my additions to > this file made the patch look indented awkwardly. > > I'll use tabs and merge it into Linux as well. > > > Thanks, > Eduard Good idea, this way more people with pci knowledge check it. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60133 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oqkoq-00044w-GM for qemu-devel@nongnu.org; Wed, 01 Sep 2010 06:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oqkoo-0004Zt-Qg for qemu-devel@nongnu.org; Wed, 01 Sep 2010 06:45:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19030) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oqkoo-0004Zi-J7 for qemu-devel@nongnu.org; Wed, 01 Sep 2010 06:45:26 -0400 Date: Wed, 1 Sep 2010 13:39:05 +0300 From: "Michael S. Tsirkin" Message-ID: <20100901103905.GB7513@redhat.com> References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> <1283007298-10942-2-git-send-email-eduard.munteanu@linux360.ro> <20100831202953.GF31570@redhat.com> <20100831225830.GA10567@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100831225830.GA10567@localhost> Subject: [Qemu-devel] Re: [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduard - Gabriel Munteanu Cc: kvm@vger.kernel.org, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, yamahata@valinux.co.jp, paul@codesourcery.com, avi@redhat.com On Wed, Sep 01, 2010 at 01:58:30AM +0300, Eduard - Gabriel Munteanu wrote: > On Tue, Aug 31, 2010 at 11:29:53PM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 28, 2010 at 05:54:52PM +0300, Eduard - Gabriel Munteanu wrote: > > > The conversion was done using the GNU 'expand' tool (default settings) > > > to make it obey the QEMU coding style. > > > > > > Signed-off-by: Eduard - Gabriel Munteanu > > > > I'm not really interested in this: we copied pci_regs.h from linux > > to help non-linux hosts, and keeping the code consistent > > with the original makes detecting bugs and adding new stuff > > from linux/pci_regs.h easier. > > > > > --- > > > hw/pci_regs.h | 1330 ++++++++++++++++++++++++++++---------------------------- > > > 1 files changed, 665 insertions(+), 665 deletions(-) > > > rewrite hw/pci_regs.h (90%) > > Ok, I'll drop it. The only reason I did it was one of my additions to > this file made the patch look indented awkwardly. > > I'll use tabs and merge it into Linux as well. > > > Thanks, > Eduard Good idea, this way more people with pci knowledge check it. -- MST