All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ux500: add ab8500-regulators machine specific data
@ 2010-09-01  8:40 Sundar Iyer
  2010-09-01 17:56 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Sundar Iyer @ 2010-09-01  8:40 UTC (permalink / raw)
  To: linux-arm-kernel

From: Sundar R Iyer <sundar.iyer@stericsson.com>

Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Acked-By: Bengt JONSSON <bengt.g.jonsson@stericsson.com>
Signed-off-by: Sundar R Iyer <sundar.iyer@stericsson.com>

v3: 
  - Empty the consumer supply definitions themselves
  - Change regulator permissions REGULATOR_CHANGE_VOLTAGE for fixed 
    supplies

v2:
  - Empty the regulator_consumer_supply since there is no actual
    device to supply

v1:
  - Removed NULL device reference

---
 arch/arm/mach-ux500/Makefile                  |    1 +
 arch/arm/mach-ux500/board-mop500-regulators.c |  143 +++++++++++++++++++++++++
 2 files changed, 144 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-ux500/board-mop500-regulators.c

diff --git a/arch/arm/mach-ux500/Makefile b/arch/arm/mach-ux500/Makefile
index 0097318..ed180b8 100644
--- a/arch/arm/mach-ux500/Makefile
+++ b/arch/arm/mach-ux500/Makefile
@@ -9,3 +9,4 @@ obj-$(CONFIG_MACH_U8500_MOP)	+= board-mop500.o board-mop500-sdi.o
 obj-$(CONFIG_MACH_U5500)	+= board-u5500.o
 obj-$(CONFIG_SMP)		+= platsmp.o headsmp.o
 obj-$(CONFIG_LOCAL_TIMERS)	+= localtimer.o
+obj-$(CONFIG_REGULATOR_AB8500)	+= board-mop500-regulators.o
diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c
new file mode 100644
index 0000000..8fcd9bb
--- /dev/null
+++ b/arch/arm/mach-ux500/board-mop500-regulators.c
@@ -0,0 +1,143 @@
+/*
+ * Copyright (C) ST-Ericsson SA 2010
+ *
+ * License Terms: GNU General Public License v2
+ *
+ * Author: Sundar Iyer <sundar.iyer@stericsson.com>
+ *
+ * MOP500 board specific initialization for regulators
+ */
+#include <linux/kernel.h>
+#include <linux/regulator/machine.h>
+
+#define AB8500_VAUXN_LDO_MIN_VOLTAGE    (1100000)
+#define AB8500_VAUXN_LDO_MAX_VOLTAGE    (3300000)
+
+struct regulator_init_data ab8500_vaux1_regulator = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vaux1",
+		.min_uV = AB8500_VAUXN_LDO_MIN_VOLTAGE,
+		.max_uV = AB8500_VAUXN_LDO_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_VOLTAGE|
+					REGULATOR_CHANGE_STATUS,
+	},
+};
+
+struct regulator_init_data ab8500_vaux2_regulator = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vaux2",
+		.min_uV = AB8500_VAUXN_LDO_MIN_VOLTAGE,
+		.max_uV = AB8500_VAUXN_LDO_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_VOLTAGE|
+					REGULATOR_CHANGE_STATUS,
+	},
+};
+
+struct regulator_init_data ab8500_vaux3_regulator = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vaux3",
+		.min_uV = AB8500_VAUXN_LDO_MIN_VOLTAGE,
+		.max_uV = AB8500_VAUXN_LDO_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_VOLTAGE|
+					REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for tvout, gpadc, TVOUT LDO */
+#define AB8500_VTVOUT_LDO_MIN_VOLTAGE        (1900000)
+#define AB8500_VTVOUT_LDO_MAX_VOLTAGE        (2100000)
+
+struct regulator_init_data ab8500_vtvout_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vtvout",
+		.min_uV = AB8500_VTVOUT_LDO_MIN_VOLTAGE,
+		.max_uV = AB8500_VTVOUT_LDO_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for ab8500-vaudio, VAUDIO LDO */
+#define AB8500_VAUDIO_REGULATOR_MIN_VOLTAGE        (1925000)
+#define AB8500_VAUDIO_REGULATOR_MAX_VOLTAGE        (2075000)
+
+struct regulator_init_data ab8500_vaudio_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vaudio",
+		.min_uV = AB8500_VAUDIO_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VAUDIO_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for v-anamic1 VAMic1-LDO */
+#define AB8500_VAMIC1_REGULATOR_MIN_VOLTAGE        (2000000)
+#define AB8500_VAMIC1_REGULATOR_MAX_VOLTAGE        (2100000)
+
+struct regulator_init_data ab8500_vamic1_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vamic1",
+		.min_uV = AB8500_VAMIC1_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VAMIC1_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for v-amic2, VAMIC2 LDO, reuse constants for AMIC1 */
+struct regulator_init_data ab8500_vamic2_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vamic2",
+		.min_uV = AB8500_VAMIC1_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VAMIC1_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for v-dmic, VDMIC LDO */
+#define AB8500_VDMIC_REGULATOR_MIN_VOLTAGE      (1700000)
+#define AB8500_VDMIC_REGULATOR_MAX_VOLTAGE      (1950000)
+
+struct regulator_init_data ab8500_vdmic_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vdmic",
+		.min_uV = AB8500_VDMIC_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VDMIC_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for v-intcore12, VINTCORE12 LDO */
+#define AB8500_VINTCORE_REGULATOR_MIN_VOLTAGE      (1200000)
+#define AB8500_VINTCORE_REGULATOR_MAX_VOLTAGE      (1350000)
+
+struct regulator_init_data ab8500_vintcore_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vintcore",
+		.min_uV = AB8500_VINTCORE_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VINTCORE_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
+/* supply for U8500 CSI/DSI, VANA LDO */
+#define AB8500_VANA_REGULATOR_MIN_VOLTAGE      (0)
+#define AB8500_VANA_REGULATOR_MAX_VOLTAGE      (1200000)
+
+struct regulator_init_data ab8500_vana_init = {
+	.supply_regulator_dev = NULL,
+	.constraints = {
+		.name = "ab8500-vana",
+		.min_uV = AB8500_VANA_REGULATOR_MIN_VOLTAGE,
+		.max_uV = AB8500_VANA_REGULATOR_MAX_VOLTAGE,
+		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+	},
+};
+
-- 
1.7.2.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [PATCH v3] ux500: add ab8500-regulators machine specific data
  2010-09-01  8:40 [PATCH v3] ux500: add ab8500-regulators machine specific data Sundar Iyer
@ 2010-09-01 17:56 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2010-09-01 17:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 01, 2010 at 02:10:11PM +0530, Sundar Iyer wrote:

> +#define AB8500_VAUXN_LDO_MIN_VOLTAGE    (1100000)
> +#define AB8500_VAUXN_LDO_MAX_VOLTAGE    (3300000)

> +struct regulator_init_data ab8500_vaux1_regulator = {

All these should be static.

> +	.supply_regulator_dev = NULL,

No need to assign to NULL, that's the default value.

> +	.constraints = {
> +		.name = "ab8500-vaux1",
> +		.min_uV = AB8500_VAUXN_LDO_MIN_VOLTAGE,
> +		.max_uV = AB8500_VAUXN_LDO_MAX_VOLTAGE,
> +		.valid_ops_mask = REGULATOR_CHANGE_VOLTAGE|
> +					REGULATOR_CHANGE_STATUS,
> +	},
> +};

Having operations for regulators with no consumers seems a bit strange.

> +/* supply for tvout, gpadc, TVOUT LDO */
> +#define AB8500_VTVOUT_LDO_MIN_VOLTAGE        (1900000)
> +#define AB8500_VTVOUT_LDO_MAX_VOLTAGE        (2100000)
> +
> +struct regulator_init_data ab8500_vtvout_init = {
> +	.supply_regulator_dev = NULL,
> +	.constraints = {
> +		.name = "ab8500-vtvout",
> +		.min_uV = AB8500_VTVOUT_LDO_MIN_VOLTAGE,
> +		.max_uV = AB8500_VTVOUT_LDO_MAX_VOLTAGE,
> +		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
> +	},
> +};

As does having voltage ranges for regulators without voltage change
permission.  Given that half the #defines you're using are only used for
one regulator it'd probably also be better to just use the values
directly.

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-01 17:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-01  8:40 [PATCH v3] ux500: add ab8500-regulators machine specific data Sundar Iyer
2010-09-01 17:56 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.