From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:32787 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754306Ab0IAS7k (ORCPT ); Wed, 1 Sep 2010 14:59:40 -0400 Date: Wed, 1 Sep 2010 14:58:57 -0400 From: "John W. Linville" To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] mac80211: cancel scan in ieee80211_restart_hw if software scan pending Message-ID: <20100901185856.GA4570@tuxdriver.com> References: <1283246981.3733.7.camel@jlt3.sipsolutions.net> <1283282737-27749-1-git-send-email-linville@tuxdriver.com> <1283336978.4131.7.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1283336978.4131.7.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Sep 01, 2010 at 12:29:38PM +0200, Johannes Berg wrote: > On Tue, 2010-08-31 at 15:25 -0400, John W. Linville wrote: > > This function exists to clean-up after a hardware error or something > > similar. The restart is accomplished using the same infrastructure used > > to resume after a suspend. The suspend path cancels running scans, so > > it seems appropriate to do that here as well for software-based scans. > > If a hardware-based scan is pending, issue a warning message since this > > indicates that the drivers has failed to clean-up after itself. > > Makes sense. > > I guess unrelated to this, I wonder if we should warn in the suspend > case as well, rather than doing it unconditionally. Hmm. Maybe so, but I'm not sure what path we would hook for that. Doesn't wiphy_suspend run before the hardware bus suspend functions? How would the driver now in advance to cancel the hardware scan? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.