All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: cancel scan in ieee80211_restart_hw if software scan pending
Date: Wed, 1 Sep 2010 16:17:24 -0400	[thread overview]
Message-ID: <20100901201723.GC4570@tuxdriver.com> (raw)
In-Reply-To: <1283368226.4124.12.camel@jlt3.sipsolutions.net>

On Wed, Sep 01, 2010 at 09:10:26PM +0200, Johannes Berg wrote:
> On Wed, 2010-09-01 at 14:58 -0400, John W. Linville wrote:
> > On Wed, Sep 01, 2010 at 12:29:38PM +0200, Johannes Berg wrote:
> > > On Tue, 2010-08-31 at 15:25 -0400, John W. Linville wrote:
> > > > This function exists to clean-up after a hardware error or something
> > > > similar.  The restart is accomplished using the same infrastructure used
> > > > to resume after a suspend.  The suspend path cancels running scans, so
> > > > it seems appropriate to do that here as well for software-based scans.
> > > > If a hardware-based scan is pending, issue a warning message since this
> > > > indicates that the drivers has failed to clean-up after itself.
> > > 
> > > Makes sense.
> > > 
> > > I guess unrelated to this, I wonder if we should warn in the suspend
> > > case as well, rather than doing it unconditionally. Hmm.
> > 
> > Maybe so, but I'm not sure what path we would hook for that.
> > Doesn't wiphy_suspend run before the hardware bus suspend functions?
> > How would the driver now in advance to cancel the hardware scan?
> 
> Good point! I was just thinking that if we do a mac80211 cancel only,
> then the scan request struct pointer that we gave to the driver earlier
> suddenly becomes invalid.

I see...how about we only cancel the software scans, then warn on
resume if the hardware scan is still running?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2010-09-01 20:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 19:14 [PATCH] mac80211: cancel scan in ieee80211_restart_hw John W. Linville
2010-08-30 19:17 ` Johannes Berg
2010-08-30 19:37   ` John W. Linville
2010-08-31  9:29     ` Johannes Berg
2010-08-31 19:25       ` [PATCH] mac80211: cancel scan in ieee80211_restart_hw if software scan pending John W. Linville
2010-09-01 10:29         ` Johannes Berg
2010-09-01 18:58           ` John W. Linville
2010-09-01 19:02             ` John W. Linville
2010-09-01 19:10             ` Johannes Berg
2010-09-01 20:17               ` John W. Linville [this message]
2010-09-02  8:29                 ` Johannes Berg
2010-09-01 20:17               ` [PATCH] mac80211: only cancel software-based scans on suspend John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901201723.GC4570@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.