From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] mkimage: Add compatibility option for legacy Multi-File images
Date: Thu, 02 Sep 2010 17:05:54 +0200 [thread overview]
Message-ID: <20100902150554.1130C153781@gemini.denx.de> (raw)
In-Reply-To: <1282164515-28846-1-git-send-email-thib@sitedethib.com>
Dear Thibaut Girka,
In message <1282164515-28846-1-git-send-email-thib@sitedethib.com> you wrote:
> During a few months, offsets of files in multi-file images were miscalculated,
> this has been fixed by 02b9b22446e3d7ad6a6382be17a1ce79a7de589b,
> but unfortunatly, some devices (I'm thinking of the Neo FreeRunner) are using
> a broken version of U-Boot.
>
> This problem can easily be worked around at image creation time by adding one
> byte of junk at the end of the first (and optionnally second) file, if its
> size is a multiple of 4.
> It's not really clean, but it shouldn't cause any problem. At least, I haven't
> encountered any using this patch.
In addition to Detlev's comments a few questions:
- Is my understanding correct that there is no problem with the
current mainline code?
- You mentioned that commit 02b9b22 (i. e. v1.3.3-rc3-46-g02b9b22)
fixed the problem - can you please also state which commit
introduced the problem?
- If so, would it then not be better to update U-Boot on the devices
that are running a broken version?
As this patch is really adding a quirk for a specific version (or set
of versions) of U-Boot only, but without general use for the current
mainline code (on contrary, it's making the code more complex without
benefit to most of us), I tend to reject this patch for mainline.
If there has been one or more released versions with this problem
present, we might consider a maintenance release for these, where we add
the commit as a workaround.
next prev parent reply other threads:[~2010-09-02 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 20:48 [U-Boot] [RFC][PATCH] mkimage: Add compatibility option for legacy Multi-File images Thibaut Girka
2010-08-30 9:29 ` Detlev Zundel
2010-08-31 6:50 ` Thibaut Girka
2010-09-01 15:04 ` Detlev Zundel
2010-09-02 15:05 ` Wolfgang Denk [this message]
2010-08-29 13:05 Per Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902150554.1130C153781@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.