All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>
Subject: Re: [PATCH 2/7] omap4: Temporary fix silicon version detection
Date: Thu, 9 Sep 2010 14:42:55 +0300	[thread overview]
Message-ID: <20100909114255.GK21060@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1284031395-25988-3-git-send-email-santosh.shilimkar@ti.com>

Hi,

On Thu, Sep 09, 2010 at 06:23:10AM -0500, Santosh Shilimkar wrote:
>@@ -308,6 +308,16 @@ static void __init omap4_check_revision(void)
> 	hawkeye = (idcode >> 12) & 0xffff;
> 	rev = (idcode >> 28) & 0xff;
>
>+	/*
>+	 * FIXME: This patch should be reverted later.
>+	 * Few initial ES2.0 samples IDCODE is same as ES1.0
>+	 * Use ARM register to detect the correct ES version
>+	 */

I wonder if it actually doesn't make sense to keep this in tree, the
overhead is minimum when rev is set correctly and it's safe for the
initial es2.0 samples which are buggy.

-- 
balbi

  parent reply	other threads:[~2010-09-09 11:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 11:23 [PATCH 0/7] omap4: Fixes, hacks for es2.0 Santosh Shilimkar
2010-09-09 11:23 ` [PATCH 1/7] omap4: Update id.c and cpu.h " Santosh Shilimkar
2010-09-09 11:23   ` [PATCH 2/7] omap4: Temporary fix silicon version detection Santosh Shilimkar
2010-09-09 11:23     ` [PATCH 3/7] omap4: l2x0: Fix init parameter for ES2.0 Santosh Shilimkar
2010-09-09 11:23       ` [PATCH 4/7] omap4: Panda: Add DEBUG_LL support Santosh Shilimkar
2010-09-09 11:23         ` [PATCH 5/7] omap4: Fix bootup crash observed with higher CPU clocks Santosh Shilimkar
2010-09-09 11:23           ` [PATCH 6/7] omap4: Workaround for CMD line reset Santosh Shilimkar
2010-09-09 11:23             ` [PATCH 7/7] KS8851: Correct RX packet allocation Santosh Shilimkar
2010-09-14 15:47             ` [PATCH 6/7] omap4: Workaround for CMD line reset kishore kadiyala
2010-09-14 15:58               ` Madhusudhan
2010-09-14 16:48                 ` Shilimkar, Santosh
2010-09-15 19:30                   ` Madhusudhan
2010-09-13 16:28       ` [PATCH 3/7] omap4: l2x0: Fix init parameter for ES2.0 Gadiyar, Anand
2010-09-13 16:37         ` Shilimkar, Santosh
2010-09-09 11:42     ` Felipe Balbi [this message]
2010-09-09 11:47       ` [PATCH 2/7] omap4: Temporary fix silicon version detection Cousson, Benoit
2010-09-09 12:02         ` Shilimkar, Santosh
2010-09-09 12:07           ` Felipe Balbi
2010-09-09 12:47             ` Cousson, Benoit
2010-09-09 15:55               ` Jon Hunter
2010-09-09 13:01             ` Shilimkar, Santosh
2010-09-09 13:24               ` Shilimkar, Santosh
2010-09-10 12:33                 ` Felipe Balbi
2010-09-10 12:46                   ` Shilimkar, Santosh
2010-09-09 15:21 ` [PATCH 0/7] omap4: Fixes, hacks for es2.0 Kevin Hilman
2010-09-09 15:28   ` Shilimkar, Santosh
2010-09-09 15:54     ` Kevin Hilman
2010-09-09 16:00       ` Shilimkar, Santosh
2010-09-10 10:30         ` Ghorai, Sukumar
2010-09-10 10:38           ` Shilimkar, Santosh
2010-09-10 15:03           ` Ricardo Salveti
2010-09-10 15:09             ` Ghorai, Sukumar
2010-09-10 15:29               ` Ricardo Salveti
2010-09-13 15:06                 ` Ghorai, Sukumar
2010-09-13 18:51                   ` Ricardo Salveti
2010-09-14  4:01                     ` Ghorai, Sukumar
2010-09-15  5:18                       ` Bryan Wu
2010-09-10 15:11             ` Shilimkar, Santosh
2010-09-10  7:14 ` Ghorai, Sukumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100909114255.GK21060@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.