From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691Ab0IIDJC (ORCPT ); Wed, 8 Sep 2010 23:09:02 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:57302 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954Ab0IIDI4 (ORCPT ); Wed, 8 Sep 2010 23:08:56 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 9 Sep 2010 12:03:45 +0900 From: KAMEZAWA Hiroyuki To: Mel Gorman Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Linux Kernel List , Rik van Riel , Johannes Weiner , Minchan Kim , Wu Fengguang , Andrea Arcangeli , KOSAKI Motohiro , Dave Chinner , Chris Mason , Christoph Hellwig , Andrew Morton Subject: Re: [PATCH 04/10] vmscan: Synchronous lumpy reclaim should not call congestion_wait() Message-Id: <20100909120345.4a7cf87c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1283770053-18833-5-git-send-email-mel@csn.ul.ie> References: <1283770053-18833-1-git-send-email-mel@csn.ul.ie> <1283770053-18833-5-git-send-email-mel@csn.ul.ie> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Sep 2010 11:47:27 +0100 Mel Gorman wrote: > From: KOSAKI Motohiro > > congestion_wait() mean "waiting queue congestion is cleared". However, > synchronous lumpy reclaim does not need this congestion_wait() as > shrink_page_list(PAGEOUT_IO_SYNC) uses wait_on_page_writeback() > and it provides the necessary waiting. > > Signed-off-by: KOSAKI Motohiro > Signed-off-by: Mel Gorman Reviewed-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id D01EF6B0078 for ; Wed, 8 Sep 2010 23:08:57 -0400 (EDT) Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o8938tc4002319 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 9 Sep 2010 12:08:55 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id B41ED45DE79 for ; Thu, 9 Sep 2010 12:08:54 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 913FF45DE70 for ; Thu, 9 Sep 2010 12:08:54 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 64F5A1DB8041 for ; Thu, 9 Sep 2010 12:08:54 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 1B5B31DB803F for ; Thu, 9 Sep 2010 12:08:54 +0900 (JST) Date: Thu, 9 Sep 2010 12:03:45 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 04/10] vmscan: Synchronous lumpy reclaim should not call congestion_wait() Message-Id: <20100909120345.4a7cf87c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1283770053-18833-5-git-send-email-mel@csn.ul.ie> References: <1283770053-18833-1-git-send-email-mel@csn.ul.ie> <1283770053-18833-5-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Linux Kernel List , Rik van Riel , Johannes Weiner , Minchan Kim , Wu Fengguang , Andrea Arcangeli , KOSAKI Motohiro , Dave Chinner , Chris Mason , Christoph Hellwig , Andrew Morton List-ID: On Mon, 6 Sep 2010 11:47:27 +0100 Mel Gorman wrote: > From: KOSAKI Motohiro > > congestion_wait() mean "waiting queue congestion is cleared". However, > synchronous lumpy reclaim does not need this congestion_wait() as > shrink_page_list(PAGEOUT_IO_SYNC) uses wait_on_page_writeback() > and it provides the necessary waiting. > > Signed-off-by: KOSAKI Motohiro > Signed-off-by: Mel Gorman Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org