From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387Ab0IISLb (ORCPT ); Thu, 9 Sep 2010 14:11:31 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:48864 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208Ab0IISL1 convert rfc822-to-8bit (ORCPT ); Thu, 9 Sep 2010 14:11:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=DGuO7xpIvipfPdKZ+5bIQ1BSuHOqObYFQBaN8K0NrY2THPCNVhvcq/c3N/sVQmsrO1 T8NNuWuSwQHsYyh5Q/CvWpzbjlUvEu5pWIupQh9YXu3kQbM2yn47wPyFqyo7UMMaXnBX c51NFNWAJKo7RMLrhdXdwys7U3aPtUBke6CSc= From: Marek Vasut Organization: Hack&Dev To: Eric Miao Subject: Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Date: Thu, 9 Sep 2010 20:11:19 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.34-1-amd64; KDE/4.4.5; x86_64; ; ) Cc: "Mark F. Brown" , linux-arm-kernel@lists.infradead.org, Haojian Zhuang , linux-kernel@vger.kernel.org References: <1283914607-10570-1-git-send-email-mark.brown314@gmail.com> <201009090321.24440.marek.vasut@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201009092011.19699.marek.vasut@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne Čt 9. září 2010 09:39:15 Eric Miao napsal(a): > On Thu, Sep 9, 2010 at 9:21 AM, Marek Vasut wrote: > > Dne Čt 9. září 2010 01:42:36 Mark F. Brown napsal(a): > >> On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut wrote: > >> > Dne St 8. září 2010 04:56:45 Mark F. Brown napsal(a): > >> > > >> > --------------------------- > >> > Description is missing here > >> > --------------------------- > >> > > >> >> Signed-off-by: Mark F. Brown > >> >> --- > >> >> arch/arm/mach-mmp/Kconfig | 7 ++++++ > >> >> arch/arm/mach-mmp/Makefile | 1 + > >> >> arch/arm/mach-mmp/teton_bga.c | 47 > >> >> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 > >> >> insertions(+), 0 deletions(-) > >> >> create mode 100644 arch/arm/mach-mmp/teton_bga.c > >> >> > >> >> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig > >> >> index 6ab843e..0711d3b 100644 > >> >> --- a/arch/arm/mach-mmp/Kconfig > >> >> +++ b/arch/arm/mach-mmp/Kconfig > >> >> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER > >> >> PXA910-based development board. Since MMP2 is compatible to > >> >> ARMv6 architecture. > >> >> > >> >> +config MACH_TETON_BGA > >> >> + bool "Marvell's PXA168 Teton BGA Development Board" > >> >> + select CPU_PXA168 > >> >> + help > >> >> + Say 'Y' here if you want to support the Marvell PXA168-based > >> >> + Teton BGA Development Board. > >> >> + > >> >> endmenu > >> >> > >> >> config CPU_PXA168 > >> >> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile > >> >> index 8b66d06..751cdbf 100644 > >> >> --- a/arch/arm/mach-mmp/Makefile > >> >> +++ b/arch/arm/mach-mmp/Makefile > >> >> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o > >> >> obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o > >> >> obj-$(CONFIG_MACH_FLINT) += flint.o > >> >> obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o > >> >> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o > >> >> diff --git a/arch/arm/mach-mmp/teton_bga.c > >> >> b/arch/arm/mach-mmp/teton_bga.c new file mode 100644 > >> >> index 0000000..014cc37 > >> >> --- /dev/null > >> >> +++ b/arch/arm/mach-mmp/teton_bga.c > >> >> @@ -0,0 +1,47 @@ > >> >> +/* > >> >> + * linux/arch/arm/mach-mmp/teton_bga.c > >> >> + * > >> >> + * Support for the Marvell PXA168 Teton BGA Development Platform. > >> > > >> > Authoring information of this file are missing. Also, MAINTAINERS > >> > entry is missing. > >> > > >> >> + * > >> >> + * This code is based on aspenite.c > >> >> + * > >> >> + * This program is free software; you can redistribute it and/or > >> >> modify + * it under the terms of the GNU General Public License > >> >> version 2 as + * publishhed by the Free Software Foundation. > >> >> + */ > >> >> + > >> >> +#include > >> >> +#include > >> >> +#include > >> >> + > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> > > >> > use ... #include > >> > > >> >> + > >> >> +#include "common.h" > >> >> + > >> >> +static unsigned long teton_bga_pin_config[] __initdata = { > >> >> + /* UART1 */ > >> >> + GPIO107_UART1_TXD, > >> >> + GPIO108_UART1_RXD, > >> >> +}; > >> >> + > >> >> +static void __init teton_bga_init(void) > >> >> +{ > >> >> + mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); > >> >> + > >> >> + /* on-chip devices */ > >> >> + pxa168_add_uart(1); > >> > > >> > Don't we have enum for these magic numbers on pxa168 ? > >> > > >> >> +} > >> >> + > >> >> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development > >> >> Platform") + .phys_io = APB_PHYS_BASE, > >> >> + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, > >> >> + .map_io = mmp_map_io, > >> >> + .init_irq = pxa168_init_irq, > >> >> + .timer = &pxa168_timer, > >> >> + .init_machine = teton_bga_init, > >> >> +MACHINE_END > >> > > >> > Cheers > >> > >> I am assuming you mean the magic number for .io_pg_offst: > >> .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, > > > > Nope, sorry, I meant this: > > > > + pxa168_add_uart(1); > > > > The (1) seems weird, but whatever. I don't have any pxa168 device. > > Actually the parameter means the device ID, so pxa168_add_uart(1) > means to add UART1 on pxa168, so it's quite straight-forward. Ah ok, sorry about the confusion. Can we see new version of this patch with my previous comments addressed ? Thanks, Cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Thu, 9 Sep 2010 20:11:19 +0200 Subject: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform In-Reply-To: References: <1283914607-10570-1-git-send-email-mark.brown314@gmail.com> <201009090321.24440.marek.vasut@gmail.com> Message-ID: <201009092011.19699.marek.vasut@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dne ?t 9. z??? 2010 09:39:15 Eric Miao napsal(a): > On Thu, Sep 9, 2010 at 9:21 AM, Marek Vasut wrote: > > Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a): > >> On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut wrote: > >> > Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a): > >> > > >> > --------------------------- > >> > Description is missing here > >> > --------------------------- > >> > > >> >> Signed-off-by: Mark F. Brown > >> >> --- > >> >> arch/arm/mach-mmp/Kconfig | 7 ++++++ > >> >> arch/arm/mach-mmp/Makefile | 1 + > >> >> arch/arm/mach-mmp/teton_bga.c | 47 > >> >> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 > >> >> insertions(+), 0 deletions(-) > >> >> create mode 100644 arch/arm/mach-mmp/teton_bga.c > >> >> > >> >> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig > >> >> index 6ab843e..0711d3b 100644 > >> >> --- a/arch/arm/mach-mmp/Kconfig > >> >> +++ b/arch/arm/mach-mmp/Kconfig > >> >> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER > >> >> PXA910-based development board. Since MMP2 is compatible to > >> >> ARMv6 architecture. > >> >> > >> >> +config MACH_TETON_BGA > >> >> + bool "Marvell's PXA168 Teton BGA Development Board" > >> >> + select CPU_PXA168 > >> >> + help > >> >> + Say 'Y' here if you want to support the Marvell PXA168-based > >> >> + Teton BGA Development Board. > >> >> + > >> >> endmenu > >> >> > >> >> config CPU_PXA168 > >> >> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile > >> >> index 8b66d06..751cdbf 100644 > >> >> --- a/arch/arm/mach-mmp/Makefile > >> >> +++ b/arch/arm/mach-mmp/Makefile > >> >> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o > >> >> obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o > >> >> obj-$(CONFIG_MACH_FLINT) += flint.o > >> >> obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o > >> >> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o > >> >> diff --git a/arch/arm/mach-mmp/teton_bga.c > >> >> b/arch/arm/mach-mmp/teton_bga.c new file mode 100644 > >> >> index 0000000..014cc37 > >> >> --- /dev/null > >> >> +++ b/arch/arm/mach-mmp/teton_bga.c > >> >> @@ -0,0 +1,47 @@ > >> >> +/* > >> >> + * linux/arch/arm/mach-mmp/teton_bga.c > >> >> + * > >> >> + * Support for the Marvell PXA168 Teton BGA Development Platform. > >> > > >> > Authoring information of this file are missing. Also, MAINTAINERS > >> > entry is missing. > >> > > >> >> + * > >> >> + * This code is based on aspenite.c > >> >> + * > >> >> + * This program is free software; you can redistribute it and/or > >> >> modify + * it under the terms of the GNU General Public License > >> >> version 2 as + * publishhed by the Free Software Foundation. > >> >> + */ > >> >> + > >> >> +#include > >> >> +#include > >> >> +#include > >> >> + > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> >> +#include > >> > > >> > use ... #include > >> > > >> >> + > >> >> +#include "common.h" > >> >> + > >> >> +static unsigned long teton_bga_pin_config[] __initdata = { > >> >> + /* UART1 */ > >> >> + GPIO107_UART1_TXD, > >> >> + GPIO108_UART1_RXD, > >> >> +}; > >> >> + > >> >> +static void __init teton_bga_init(void) > >> >> +{ > >> >> + mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); > >> >> + > >> >> + /* on-chip devices */ > >> >> + pxa168_add_uart(1); > >> > > >> > Don't we have enum for these magic numbers on pxa168 ? > >> > > >> >> +} > >> >> + > >> >> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development > >> >> Platform") + .phys_io = APB_PHYS_BASE, > >> >> + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, > >> >> + .map_io = mmp_map_io, > >> >> + .init_irq = pxa168_init_irq, > >> >> + .timer = &pxa168_timer, > >> >> + .init_machine = teton_bga_init, > >> >> +MACHINE_END > >> > > >> > Cheers > >> > >> I am assuming you mean the magic number for .io_pg_offst: > >> .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, > > > > Nope, sorry, I meant this: > > > > + pxa168_add_uart(1); > > > > The (1) seems weird, but whatever. I don't have any pxa168 device. > > Actually the parameter means the device ID, so pxa168_add_uart(1) > means to add UART1 on pxa168, so it's quite straight-forward. Ah ok, sorry about the confusion. Can we see new version of this patch with my previous comments addressed ? Thanks, Cheers