From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: gitweb: please show tags file history browsing Date: Sun, 12 Sep 2010 12:19:57 +0200 Message-ID: <201009121219.58191.jnareb@gmail.com> References: <000001cb51be$ed214dd0$c763e970$@se> <000d01cb525c$c6c2b8b0$54482a10$@se> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org To: "Tjernlund" X-From: git-owner@vger.kernel.org Sun Sep 12 12:21:56 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oujh5-0000A6-Lp for gcvg-git-2@lo.gmane.org; Sun, 12 Sep 2010 12:21:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836Ab0ILKVi (ORCPT ); Sun, 12 Sep 2010 06:21:38 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:42496 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045Ab0ILKVh (ORCPT ); Sun, 12 Sep 2010 06:21:37 -0400 Received: by fxm16 with SMTP id 16so2627694fxm.19 for ; Sun, 12 Sep 2010 03:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=3DkDWtefz8TX0u2VmHkGNA4B9EwWoixwrG1EKRPYwZE=; b=grlMLdDCtBMQviz1sEPIorNJ4BxN5efzXZeqfODDFA3oxuXqBLJobmxyQhfvykxICK +Z+Ygq9hsDZmze/inqQwMD+wF39oWM7hMeigaIydc6Cxw1nKSE0B1ToIzY6Wy78a4iz1 ZUBV5iZyzjCCO6p+wId+s53tVWNPp4yK6Te3I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=SMi+nElYnA/6+iR6G4pcmHxdR9cCiVKEv5SEZpLYN4lzrvQPKZXebtxC+S/8b+2VkK dhJHFk/osO7iGeoqSAZjldK8qW68d8wQ4uBveQaSpJC4+V6AdOK6Boynsw8FgNa9z43B 80yn2o0RmLIoRtWHDzyTGLw6lJRIGBBaTVRKE= Received: by 10.223.103.148 with SMTP id k20mr2193227fao.37.1284286808673; Sun, 12 Sep 2010 03:20:08 -0700 (PDT) Received: from [192.168.1.13] (abwi198.neoplus.adsl.tpnet.pl [83.8.232.198]) by mx.google.com with ESMTPS id b9sm2263962faq.7.2010.09.12.03.20.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 12 Sep 2010 03:20:07 -0700 (PDT) User-Agent: KMail/1.9.3 In-Reply-To: <000d01cb525c$c6c2b8b0$54482a10$@se> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, 12 Sep 2010, Tjernlund wrote: > > -----Original Message----- > > From: Jakub Narebski [mailto:jnareb@gmail.com] > > > > "Tjernlund" writes: > > > > > I would really like to see where the tags are when browsing > > > file or directory history in gitweb. Would that be possible? > > While it probably be possible to show tags in 'history' view, it would > > be not easy. The problem is that 'history' view shows only commits > > that touch specified file or directory, and tagged commits usually do > > not touch those files (at least if one is using "bump version number" > > commits to tag them). > > > > So you would have: > > 1. Design where to show those tags - they would be between shown > > commits. > > 2. Create code which shows some/all tags that are between commits in > > the presence of nonlinear history, without affecting performance > > too badly. > > Ah, that is too bad because I think it would really useful. > Image browsing a drivers history in the linux kernel. Then it would be > really nice to see what changes/bug fixes went into what release. First, you can help with the first issue even if you can't help with the coding itself. Second, with single 'git name-rev --tags --stdin' or with '--decorate' or '%d' in format we could (I think) either display at least some tags, or name-rev decorations, i.e. something like: (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers (v1.7.3-rc0~44) Merge branch 'maint' (v1.7.2.3~15) Typos in code comments, an error message, documentation (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf' (v1.7.3-rc0~92) Merge branch 'maint' (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found [...] If we want to display all tags we would have IIUC extend git-log to generate such information. -- Jakub Narebski Poland