All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] PM_SLEEP_SMP: fix kconfig warning
Date: Sun, 12 Sep 2010 21:36:11 +0200	[thread overview]
Message-ID: <201009122136.11660.rjw@sisk.pl> (raw)
In-Reply-To: <4C8D210D.8080307@oracle.com>

On Sunday, September 12, 2010, Randy Dunlap wrote:
> On 09/12/10 10:26, Rafael J. Wysocki wrote:
> > On Sunday, September 12, 2010, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> Fix kconfig unmet dependency warning:
> >>
> >> warning: (PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE) && PM_SLEEP) selects HOTPLUG_CPU which has unmet direct dependencies (SMP && HOTPLUG)
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >> ---
> >>  kernel/power/Kconfig |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- linux-next-20100908.orig/kernel/power/Kconfig
> >> +++ linux-next-20100908/kernel/power/Kconfig
> >> @@ -83,7 +83,7 @@ config PM_TRACE_RTC
> >>  
> >>  config PM_SLEEP_SMP
> >>  	bool
> >> -	depends on SMP
> >> +	depends on SMP && HOTPLUG
> >>  	depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> >>  	depends on PM_SLEEP
> >>  	select HOTPLUG_CPU
> > 
> > I'm afraid that may cause some people to find that suspend is not compiled in
> > to their surprise.
> > 
> > Would it be possible to select both HOTPLUG and HOTPLUG_CPU instead (ie. would
> > that work)?
> 
> That appears to work in my testing.  I'll ack your patch.
> 
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

OK, thanks!

Appended for completness, I'm going to put it into my linux-next branch.

Rafael

---
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: PM: Fix unmet dependency warning from kconfig

Fix the following build warning:

warning: (PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || \
ARCH_HIBERNATION_POSSIBLE) && PM_SLEEP) selects HOTPLUG_CPU which \
has unmet direct dependencies (SMP && HOTPLUG)

by selecting HOTPLUG along with CPU_HOTPLUG.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 kernel/power/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/kernel/power/Kconfig
===================================================================
--- linux-2.6.orig/kernel/power/Kconfig
+++ linux-2.6/kernel/power/Kconfig
@@ -86,6 +86,7 @@ config PM_SLEEP_SMP
 	depends on SMP
 	depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
 	depends on PM_SLEEP
+	select HOTPLUG
 	select HOTPLUG_CPU
 	default y
 

  reply	other threads:[~2010-09-12 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-11 22:57 [PATCH] PM_SLEEP_SMP: fix kconfig warning Randy Dunlap
2010-09-12 17:26 ` Rafael J. Wysocki
2010-09-12 18:50   ` Randy Dunlap
2010-09-12 18:50   ` Randy Dunlap
2010-09-12 19:36     ` Rafael J. Wysocki [this message]
2010-09-12 19:36     ` Rafael J. Wysocki
2010-09-12 17:26 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2010-09-11 22:57 Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009122136.11660.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.