From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Chris Ball <cjb@laptop.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller
Date: Mon, 13 Sep 2010 12:48:38 +0200 [thread overview]
Message-ID: <201009131248.38501.arnd@arndb.de> (raw)
In-Reply-To: <1284366279-17140-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Monday 13 September 2010, Mark Brown wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index ce099c4..5fa4e2b 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -133,6 +133,7 @@ config MMC_SDHCI_CNS3XXX
> config MMC_SDHCI_MV
> tristate "SDHCI support on Marvell's SoC"
> depends on MMC_SDHCI
> + depends on (PLAT_PXA || PLAT_ORION)
> select MMC_SDHCI_IO_ACCESSORS
> help
> This selects the Secure Digital Host Controller Interface in
I think we normally try to do the the other way round: in order to increase
build coverage, try to enable all drivers on as many platforms as possible,
just don't have them in the defconfig.
Do you get build errors on other platforms? If yes, there is probably
a bug in the driver that should be fixed instead.
Arnd
next prev parent reply other threads:[~2010-09-13 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:24 [PATCH] mmc: Add architecture dependency for Marvell SoC controller Mark Brown
2010-09-13 10:48 ` Arnd Bergmann [this message]
2010-09-13 12:02 ` Mark Brown
2010-09-14 19:05 ` Chris Ball
2010-09-15 9:40 ` Mark Brown
2010-09-15 9:55 ` Saeed Bishara
2010-09-15 11:00 ` Mark Brown
2010-09-15 10:06 ` Saeed Bishara
2010-09-15 11:20 ` Haojian Zhuang
2010-09-15 10:29 ` Saeed Bishara
2010-09-15 11:59 ` Haojian Zhuang
2010-09-15 20:59 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009131248.38501.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.