Re: [PATCH 00/16] Nested virtualization for VMX

From: Tim Deegan <Tim.Deegan@citrix.com>
To: Qing He <qing.he@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"eddie.dong@intel.com" <eddie.dong@intel.com>
Subject: Re: [PATCH 00/16] Nested virtualization for VMX
Date: Mon, 13 Sep 2010 14:10:22 +0100	[thread overview]
Message-ID: <20100913131022.GG3844@whitby.uk.xensource.com> (raw)
In-Reply-To: <1283959344-3837-1-git-send-email-qing.he@intel.com>

Hi, 

Thanks for this updated patchset, and for addressing a lot of what I
mentioned last time.  I've made a few comments on individual patches;
since the nested EPT changes aren't in the series this time I don't
think any of it needs an explicit ack from me with my x86-mm-maintainer
hat on.

Apart from that I'll say again that some common code should be found
between these and the SVM patches, if that's possible.  Not necessarily
the interface that Christoph is proposing, but since he's gone to the
effort it seems like a good starting point.

I would certainly like to see common interrupt-routing changes next time
these patches are posted, even if we're still discussing the vmexit
path.

Cheers,

Tim.

At 16:22 +0100 on 08 Sep (1283962928), Qing He wrote:
> This patch set is the upgraded version of nested
> virtualization for VMX, that allows a VMX guest (L1) to
> run other VMX guests (L2).
> 
> The nested virtualization for vmx is built on homogeneous
> L1 and L2 for better performance and minimal emulation,
> the common code involved is small and contained in patch
> 03/16, for two flags, one for feature availability, the
> other for indicating current mode.
> 
> The userspace components (xend/xm/xl) is not included since
> Christopher's userspace patch has similar coverage. vEPT is
> not included as well because it's still WIP.
> 
> Major changes to last version:
>  - address Tim's comments on error handling and others
>  - split context switch into smaller pieces with certain
>    restructure for better readability
>  - update interrupt handling, rewrite comments
>  - move cpuid into userspace
>  - etc.
> 
> The patch set includes the following patches.
> 
> [PATCH 01/16] vmx: nest: rename host_vmcs
> [PATCH 02/16] vmx: nest: wrapper for control update
> [PATCH 03/16] vmx: nest: nested availability and status flags
> [PATCH 04/16] vmx: nest: nested control structure
> [PATCH 05/16] vmx: nest: virtual vmcs layout
> [PATCH 06/16] vmx: nest: handling VMX instruction exits
> [PATCH 07/16] vmx: nest: switch current vmcs
> [PATCH 08/16] vmx: nest: vmresume/vmlaunch
> [PATCH 09/16] vmx: nest: shadow controls
> [PATCH 10/16] vmx: nest: L1 <-> L2 context switch
> [PATCH 11/16] vmx: nest: interrupt handling
> [PATCH 12/16] vmx: nest: VMExit handler in L2
> [PATCH 13/16] vmx: nest: L2 tsc
> [PATCH 14/16] vmx: nest: CR0.TS and #NM
> [PATCH 15/16] vmx: nest: capability reporting MSRs
> [PATCH 16/16] vmx: nest: expose cpuid and CR4.VMXE
> 
> Thanks,
> Qing He
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)