All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: qemu-devel@nongnu.org, av1474@comtv.ru, kvm@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] [RFC] Add support for a USB audio device model
Date: Tue, 14 Sep 2010 04:53:39 +0800	[thread overview]
Message-ID: <20100913205338.GA2607@z> (raw)
In-Reply-To: <1284155276-14959-1-git-send-email-hpa@linux.intel.com>

On Fri, Sep 10, 2010 at 02:47:56PM -0700, H. Peter Anvin wrote:
> I discovered that none of the audio device models supported by current
> Qemu/KVM appear to be supported out of the box on Win7 64 bit (AC97
> works fine on 32 bit).  The most logical ways to fix that would be to
> add a long-term supportable audio device model.  Intel HD Audio and
> USB Audio seemed like the most reasonable options, but I opted for USB
> Audio for a few reasons:

...
> diff --git a/configure b/configure
> index 8228c1c..4fcb829 100755
> --- a/configure
> +++ b/configure
> @@ -71,8 +71,8 @@ sparc_cpu=""
>  cross_prefix=""
>  cc="gcc"
>  audio_drv_list=""
> -audio_card_list="ac97 es1370 sb16"
> -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus"
> +audio_card_list="ac97 es1370 sb16 usb-audio"
> +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus usb-audio"
>  block_drv_whitelist=""
>  host_cc="gcc"
>  ar="ar"
> @@ -2414,7 +2414,7 @@ if test "$vde" = "yes" ; then
>  fi
>  for card in $audio_card_list; do
>      def=CONFIG_`echo $card | tr '[:lower:]' '[:upper:]'`
> -    echo "$def=y" >> $config_host_mak
> +    echo ${def//-/_}=y >> $config_host_mak
>  done
>  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
>  for drv in $audio_drv_list; do

# patch -p1 < /tmp/usb-audio.patch
# ./configure
...
...
preadv support    yes
fdatasync         yes
uuid support      no
vhost-net support no
Trace backend     nop
Trace output file trace-<pid>
./configure: 2276: Bad substitution


> diff --git a/create_config b/create_config
> index 0098e68..1caa25b 100755
> --- a/create_config
> +++ b/create_config
> @@ -25,7 +25,7 @@ case $line in
>   CONFIG_AUDIO_DRIVERS=*)
>      drivers=${line#*=}
>      echo "#define CONFIG_AUDIO_DRIVERS \\"
> -    for drv in $drivers; do
> +    for drv in ${drivers//-/_}; do
>        echo "    &${drv}_audio_driver,\\"
>      done
>      echo ""
> @@ -39,10 +39,12 @@ case $line in
>      ;;
>   CONFIG_*=y) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      echo "#define $name 1"
>      ;;
>   CONFIG_*=*) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      value=${line#*=}
>      echo "#define $name $value"
>      ;;

...


WARNING: multiple messages have this Message-ID
From: Amos Kong <akong@redhat.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model
Date: Tue, 14 Sep 2010 04:53:39 +0800	[thread overview]
Message-ID: <20100913205338.GA2607@z> (raw)
In-Reply-To: <1284155276-14959-1-git-send-email-hpa@linux.intel.com>

On Fri, Sep 10, 2010 at 02:47:56PM -0700, H. Peter Anvin wrote:
> I discovered that none of the audio device models supported by current
> Qemu/KVM appear to be supported out of the box on Win7 64 bit (AC97
> works fine on 32 bit).  The most logical ways to fix that would be to
> add a long-term supportable audio device model.  Intel HD Audio and
> USB Audio seemed like the most reasonable options, but I opted for USB
> Audio for a few reasons:

...
> diff --git a/configure b/configure
> index 8228c1c..4fcb829 100755
> --- a/configure
> +++ b/configure
> @@ -71,8 +71,8 @@ sparc_cpu=""
>  cross_prefix=""
>  cc="gcc"
>  audio_drv_list=""
> -audio_card_list="ac97 es1370 sb16"
> -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus"
> +audio_card_list="ac97 es1370 sb16 usb-audio"
> +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus usb-audio"
>  block_drv_whitelist=""
>  host_cc="gcc"
>  ar="ar"
> @@ -2414,7 +2414,7 @@ if test "$vde" = "yes" ; then
>  fi
>  for card in $audio_card_list; do
>      def=CONFIG_`echo $card | tr '[:lower:]' '[:upper:]'`
> -    echo "$def=y" >> $config_host_mak
> +    echo ${def//-/_}=y >> $config_host_mak
>  done
>  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
>  for drv in $audio_drv_list; do

# patch -p1 < /tmp/usb-audio.patch
# ./configure
...
...
preadv support    yes
fdatasync         yes
uuid support      no
vhost-net support no
Trace backend     nop
Trace output file trace-<pid>
./configure: 2276: Bad substitution


> diff --git a/create_config b/create_config
> index 0098e68..1caa25b 100755
> --- a/create_config
> +++ b/create_config
> @@ -25,7 +25,7 @@ case $line in
>   CONFIG_AUDIO_DRIVERS=*)
>      drivers=${line#*=}
>      echo "#define CONFIG_AUDIO_DRIVERS \\"
> -    for drv in $drivers; do
> +    for drv in ${drivers//-/_}; do
>        echo "    &${drv}_audio_driver,\\"
>      done
>      echo ""
> @@ -39,10 +39,12 @@ case $line in
>      ;;
>   CONFIG_*=y) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      echo "#define $name 1"
>      ;;
>   CONFIG_*=*) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      value=${line#*=}
>      echo "#define $name $value"
>      ;;

...

  parent reply	other threads:[~2010-09-13 20:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 21:47 [PATCH] [RFC] Add support for a USB audio device model H. Peter Anvin
2010-09-10 21:47 ` [Qemu-devel] " H. Peter Anvin
2010-09-11  0:28 ` malc
2010-09-11  0:28   ` [Qemu-devel] " malc
2010-09-11  1:08   ` H. Peter Anvin
2010-09-11  1:08     ` [Qemu-devel] " H. Peter Anvin
2010-09-11  2:47     ` H. Peter Anvin
2010-09-11  2:47       ` H. Peter Anvin
2010-09-11  3:05       ` H. Peter Anvin
2010-09-11  3:05         ` H. Peter Anvin
2010-09-11 13:53         ` malc
2010-09-11 17:09           ` H. Peter Anvin
2010-09-11 13:14     ` Alexander Graf
2010-09-11 13:14       ` [Qemu-devel] " Alexander Graf
2010-09-11 18:29       ` H. Peter Anvin
2010-09-11 18:29         ` [Qemu-devel] " H. Peter Anvin
2010-09-11  7:41 ` Stefan Hajnoczi
2010-09-11  7:41   ` [Qemu-devel] " Stefan Hajnoczi
2010-09-12  5:20   ` H. Peter Anvin
2010-09-12  5:20     ` [Qemu-devel] " H. Peter Anvin
2010-09-13 20:53 ` Amos Kong [this message]
2010-09-13 20:53   ` Amos Kong
2010-09-13 21:04   ` H. Peter Anvin
2010-09-13 21:04     ` [Qemu-devel] " H. Peter Anvin
2010-09-14  1:37     ` Amos Kong
2010-09-14  1:37       ` [Qemu-devel] " Amos Kong
2010-09-14  5:56       ` H. Peter Anvin
2010-09-14  5:56         ` [Qemu-devel] " H. Peter Anvin
2010-10-14 13:51         ` Mike Snitzer
2010-10-14 13:51           ` [Qemu-devel] " Mike Snitzer
2010-10-14 15:40           ` H. Peter Anvin
2010-10-14 15:40             ` [Qemu-devel] " H. Peter Anvin
2010-10-14 16:18             ` Alon Levy
2010-10-14 17:43               ` H. Peter Anvin
2010-09-13 21:07   ` H. Peter Anvin
2010-09-13 21:07     ` [Qemu-devel] " H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913205338.GA2607@z \
    --to=akong@redhat.com \
    --cc=av1474@comtv.ru \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.