All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [GIT PULL 0/1] perf/core ui browser improvement
Date: Mon, 13 Sep 2010 18:29:52 -0300	[thread overview]
Message-ID: <20100913212951.GI31907@ghostprotocols.net> (raw)
In-Reply-To: <20100913204217.GA2505@elte.hu>

Em Mon, Sep 13, 2010 at 10:42:17PM +0200, Ingo Molnar escreveu:
> > Em Mon, Sep 13, 2010 at 07:48:45PM +0200, Ingo Molnar escreveu:
> > > Nice, it's more economic with screen real estate now :-)
> > > 
> > > btw., a small detail: could we please rename [kernel.kallsyms] to 
> > > [kernel]? The user is not really interested where the symbols came from 
> > > (kallsyms or vmlinux), in 99.9% of the cases - and the many repetitive 
> > > .kallsyms instances look uninformative and somewhat confusing.
> > 
> > Sure, I'll probably even remove the brackets :-)
> 
> The brackets kind of make sense, they signal that it's a container 
> (which it is) - same for DSOs.

+      3.00%         find  [kernel.kallsyms]   [k] n_tty_write
+      2.59%         find  [kernel.kallsyms]   [k] _raw_spin_lock_irqsave
+      2.43%         find  find                [.] knuth_morris_pratt_unibyte
+      2.22%         sshd  sshd                [.]            41841
+      2.16%      swapper  [kernel.kallsyms]   [k] mwait_idle
+      1.65%         find  libc-2.12.so        [.] __GI_vfprintf                   

Right now DSOs doesn't use brackets, just the kernel and modules, that
differentiates them from userspace DSOs, but then there is the next
column, where we have (under brackets) "k", "." or "H" for kernel,
userspace, hypervisor, so we can use this info to know the context, no
need for brackets around the DSO as well.

Arguably I'd remove also the brackets around the context, they also
don't convey useful information IMHO, and also would replace '.' with
'u', so it would become:

+      3.00%         find  kernel       k n_tty_write
+      2.59%         find  kernel       k _raw_spin_lock_irqsave
+      2.43%         find  find         u knuth_morris_pratt_unibyte
+      2.22%         sshd  sshd         u            41841
+      2.16%      swapper  kernel       k mwait_idle
+      1.65%         find  libc-2.12.so u __GI_vfprintf                   

Something else that is missing in the tui is a header with the names of
the columns, that is present in the stdio based formatter.

- Arnaldo

  reply	other threads:[~2010-09-13 21:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 16:34 [GIT PULL 0/1] perf/core ui browser improvement Arnaldo Carvalho de Melo
2010-09-13 16:34 ` [PATCH 1/1] perf ui browser: Don't use windows, slang is enough Arnaldo Carvalho de Melo
2010-09-13 17:48 ` [GIT PULL 0/1] perf/core ui browser improvement Ingo Molnar
2010-09-13 19:07   ` Arnaldo Carvalho de Melo
2010-09-13 20:42     ` Ingo Molnar
2010-09-13 21:29       ` Arnaldo Carvalho de Melo [this message]
2010-09-14  7:54         ` Peter Zijlstra
2010-09-14 12:16           ` Ingo Molnar
2010-09-14 13:07             ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913212951.GI31907@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.