From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54336 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvXiy-0007Ek-Tp
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:47:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OvXiw-0004D0-PU
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:47:12 -0400
Received: from mail-ew0-f45.google.com ([209.85.215.45]:64542)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OvXiw-0004Co-Jw
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:47:10 -0400
Received: by ewy27 with SMTP id 27so3636680ewy.4
	for <qemu-devel@nongnu.org>; Tue, 14 Sep 2010 08:47:09 -0700 (PDT)
Date: Tue, 14 Sep 2010 17:47:05 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1
Message-ID: <20100914154705.GA15837@laped.lan>
References: <1284411690-3557-1-git-send-email-hpoussin@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1284411690-3557-1-git-send-email-hpoussin@reactos.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On Mon, Sep 13, 2010 at 11:01:30PM +0200, Hervé Poussineau wrote:
> Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them
> This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1


Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>


> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  slirp/ip_input.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 0fe0ff7..768ab0c 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -144,7 +144,7 @@ ip_input(struct mbuf *m)
>  	   m_adj(m, ip->ip_len - m->m_len);
>  
>  	/* check ip_ttl for a correct ICMP reply */
> -	if(ip->ip_ttl==0 || ip->ip_ttl==1) {
> +	if(ip->ip_ttl==0) {
>  	  icmp_error(m, ICMP_TIMXCEED,ICMP_TIMXCEED_INTRANS, 0,"ttl");
>  	  goto bad;
>  	}
> -- 
> 1.7.1.GIT
> 
>