From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755840Ab0INX1x (ORCPT ); Tue, 14 Sep 2010 19:27:53 -0400 Received: from kroah.org ([198.145.64.141]:60188 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755378Ab0INX1w (ORCPT ); Tue, 14 Sep 2010 19:27:52 -0400 Date: Tue, 14 Sep 2010 16:26:24 -0700 From: Greg KH To: Haiyang Zhang Cc: Greg KH , "'devel@driverdev.osuosl.org'" , "'virtualization@lists.osdl.org'" , "'linux-kernel@vger.kernel.org'" Subject: Re: [PATCH 1/1] staging: hv: Convert vmbus driver interface function pointer table to constant Message-ID: <20100914232624.GA1350@kroah.com> References: <1FB5E1D5CA062146B38059374562DF72854C94CE@TK5EX14MBXC130.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1FB5E1D5CA062146B38059374562DF72854C94CE@TK5EX14MBXC130.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2010 at 02:53:03PM +0000, Haiyang Zhang wrote: > > From: Greg KH [mailto:gregkh@suse.de] > > Sent: Wednesday, September 08, 2010 6:44 PM > > > Convert vmbus driver interface function pointer table to constant > > > The vmbus interface functions are assigned to a constant - vmbus_ops. > > > > You also remove a function pointer in this patch, why? Please break up > > the patch into logical parts, one patch, one thing. > > > > This looks like it should be 2 patches, right? > > Because the vmbus interface function pointer table is converted to a > constant variable -- vmbus_ops, the function GetChannelInterface(), > VmbusGetChannelInterface() and pointer GetChannelInterface are no longer > in use. The deprecated function's work is done by the initialization of > the newly added constant variable vmbus_ops. > > I created the new constant variable vmbus_ops and removed the deprecated > function pointer GetChannelInterface in one patch. Great, next time say that in the patch please :) I'll go edit the wording and apply this... thanks, greg k-h