All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: "Balbi, Felipe" <balbi@ti.com>, Ming Lei <tom.leiming@gmail.com>,
	"greg@kroah.com" <greg@kroah.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Brownell <dbrownell@users.sourceforge.net>,
	"Gadiyar, Anand" <gadiyar@ti.com>,
	Mike Frysinger <vapier@gentoo.org>
Subject: Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over
Date: Wed, 15 Sep 2010 13:31:52 +0300	[thread overview]
Message-ID: <20100915103152.GM3393@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4C909F99.9050300@mvista.com>

Hi,

On Wed, Sep 15, 2010 at 05:27:37AM -0500, Sergei Shtylyov wrote:
>    IMHO, this fix as it is now is quite stupid. It's clear that the check is
>misplaced and will be removed once the ZLP fix is done. So why not do it once

your forgetting the fact that not always you need to send ZLP after
completing a packet_size-aligned transfer, so that check will have to
stay where it is.

>and for all? Is it so hard to do? FWIW, I NAK this patch as it is now.

ok, but I don't.

-- 
balbi

  reply	other threads:[~2010-09-15 10:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07 15:23 [RESEND/PATCH 0/6] USB: musb-gadget: bug fix tom.leiming
2010-09-07 15:23 ` tom.leiming-Re5JQEeQqe8AvxtiuMwx3w
2010-09-07 15:23 ` [RESEND/PATCH 1/6] USB: musb-gadget: fix kernel panic if using out ep with FIFO_TXRX style(v1) tom.leiming
2010-09-07 15:23 ` [RESEND/PATCH 2/6] USB: musb-gadget: fix bulk IN infinite hangs in double buffer case tom.leiming
2010-09-07 15:23 ` [RESEND/PATCH 3/6] USB: musb-gadget: enable autoclear for OUT transfer in both DMA 0 and DMA 1 tom.leiming
2010-09-07 15:23 ` [RESEND/PATCH 4/6] USB: musb-gadget: fix DMA length for OUT transfer tom.leiming
2010-09-07 15:23   ` tom.leiming-Re5JQEeQqe8AvxtiuMwx3w
2010-09-07 15:23 ` [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over tom.leiming
2010-09-07 15:23   ` tom.leiming-Re5JQEeQqe8AvxtiuMwx3w
2010-09-13 12:27   ` Sergei Shtylyov
2010-09-13 14:34     ` Ming Lei
2010-09-13 14:34       ` Ming Lei
2010-09-13 15:51       ` Sergei Shtylyov
2010-09-13 16:26         ` Sergei Shtylyov
2010-09-14  6:56           ` Felipe Balbi
2010-09-14 10:46             ` Sergei Shtylyov
2010-09-14 10:46               ` Sergei Shtylyov
2010-09-14 10:54               ` Felipe Balbi
2010-09-14 10:54                 ` Felipe Balbi
2010-09-14 17:51                 ` Sergei Shtylyov
2010-09-14 17:51                   ` Sergei Shtylyov
2010-09-15  6:53                   ` Felipe Balbi
2010-09-15  9:56                     ` Ming Lei
2010-09-15 10:01                     ` Sergei Shtylyov
2010-09-15 10:05                       ` Felipe Balbi
2010-09-15 10:08                         ` Sergei Shtylyov
2010-09-15 10:14                           ` Ming Lei
2010-09-15 10:18                             ` Sergei Shtylyov
2010-09-15 10:22                               ` Felipe Balbi
2010-09-15 10:22                                 ` Felipe Balbi
2010-09-15 10:27                                 ` Sergei Shtylyov
2010-09-15 10:27                                   ` Sergei Shtylyov
2010-09-15 10:31                                   ` Felipe Balbi [this message]
2010-09-15 10:41                                     ` Sergei Shtylyov
2010-09-15 10:52                                       ` Felipe Balbi
2010-09-15 13:02                                         ` Sergei Shtylyov
2010-09-15 10:37                                   ` Ming Lei
2010-09-07 15:23 ` [RESEND/PATCH 6/6] USB: musb-gadget: fix dma length in txstate tom.leiming
2010-09-07 15:23   ` tom.leiming-Re5JQEeQqe8AvxtiuMwx3w
2010-09-14 17:43   ` Sergei Shtylyov
2010-09-15  7:09     ` Felipe Balbi
2010-09-08  2:19 ` [RESEND/PATCH 0/6] USB: musb-gadget: bug fix Greg KH
2010-09-08  4:32   ` Ming Lei
2010-09-08  4:32     ` Ming Lei
2010-09-08  6:18     ` Greg KH
2010-09-08  6:18       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100915103152.GM3393@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gadiyar@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    --cc=tom.leiming@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.