From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113Ab0IOLqX (ORCPT ); Wed, 15 Sep 2010 07:46:23 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:35796 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907Ab0IOLqV (ORCPT ); Wed, 15 Sep 2010 07:46:21 -0400 Date: Wed, 15 Sep 2010 13:45:56 +0200 From: Ingo Molnar To: Frederic Weisbecker Cc: mingo@redhat.com, hpa@zytor.com, acme@redhat.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, will.deacon@arm.com, matthltc@us.ibm.com, mahesh@linux.vnet.ibm.com, rostedt@goodmis.org, tglx@linutronix.de, prasad@linux.vnet.ibm.com, greenrd@greenrd.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] hw breakpoints: Fix pid namespace bug Message-ID: <20100915114556.GA18760@elte.hu> References: <20100915114150.GA5621@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100915114150.GA5621@nowhere> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -0.4 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-0.4 required=5.9 tests=BAYES_00,URG_BIZ autolearn=no SpamAssassin version=3.2.5 1.6 URG_BIZ BODY: Contains urgent matter -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > On Wed, Sep 15, 2010 at 10:03:06AM +0000, tip-bot for Matt Helsley wrote: > > Commit-ID: d958077d007d98125766d11e82da2fd6497b91d6 > > Gitweb: http://git.kernel.org/tip/d958077d007d98125766d11e82da2fd6497b91d6 > > Author: Matt Helsley > > AuthorDate: Mon, 13 Sep 2010 13:01:18 -0700 > > Committer: Ingo Molnar > > CommitDate: Wed, 15 Sep 2010 10:43:59 +0200 > > > > hw breakpoints: Fix pid namespace bug > > > > Hardware breakpoints can't be registered within pid namespaces > > because tsk->pid is passed rather than the pid in the current > > namespace. > > > > (See https://bugzilla.kernel.org/show_bug.cgi?id=17281 ) > > > > This is a quick fix demonstrating the problem but is not the > > best method of solving the problem since passing pids internally > > is not the best way to avoid pid namespace bugs. Subsequent patches > > will show a better solution. > > > > Much thanks to Frederic Weisbecker for doing the > > bulk of the work finding this bug. > > > > Signed-off-by: Matt Helsley > > Signed-off-by: Peter Zijlstra > > Cc: Robin Green > > Cc: Prasad > > Cc: Arnaldo Carvalho de Melo > > Cc: Steven Rostedt > > Cc: Will Deacon > > Cc: Mahesh Salgaonkar > > LKML-Reference: > > Signed-off-by: Ingo Molnar > > --- > > > Aiie, you have been too fast too apply that on -tip, [...] Came from Peter. > [...] especially it should go to perf/urgent with some stable backport > tags. And I need to test them as he said that was only compile tested. No problem, mind cherry-picking it into an urgent pull request? The overlap is not an issue. > Lemme just check it really fixes the issue and I'll package his three > patches in according pull requests. Ok! Thanks, Ingo