From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH 15/16] vmx: nest: capability reporting MSRs Date: Wed, 15 Sep 2010 16:45:18 +0200 Message-ID: <201009151645.19714.Christoph.Egger@amd.com> References: <1283959344-3837-1-git-send-email-qing.he@intel.com> <201009151205.09118.Christoph.Egger@amd.com> <1A42CE6F5F474C41B63392A5F80372B22A8C23B3@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B22A8C23B3@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: "xen-devel@lists.xensource.com" , "He, Qing" List-Id: xen-devel@lists.xenproject.org On Wednesday 15 September 2010 16:28:29 Dong, Eddie wrote: > Christoph Egger wrote: > > On Wednesday 08 September 2010 17:22:23 Qing He wrote: > >> handles VMX capability reporting MSRs. > >> Some features are masked so L1 would see a rather > >> simple configuration > >> > >> Signed-off-by: Qing He > >> Signed-off-by: Eddie Dong > > > > Are there any vmx capability features that are read out via cpuid ? > > If yes, then that code belongs into the tools patch. > > That is in 16.txt, you can include in your code. Once you fixed the MAX > LEAF issue, I can ack that patch. Andre tried you to explain why the MAXLEAF change is not a problem. Is there an other problem ? > > > In SVM the nestedhvm_vcpu_features hook is empty and for MSRs > > there are already two msr hooks namely msr_read_intercept and > > msr_write_intercept. I assume the functions below all called from > > there directly or indirectly. > > No. this interception is for L1 guest. Yes, that is how I understood. What I mean is that you can call the functions from vmx_msr_read_intercept/vmx_msr_write_intercept. > > > That renders the nestedhvm_vcpu_features hook useless and will remove > > it. > > A step toward my wish of light weight wrapper, glad to see! I would have removed it earlier, if you were telling me what I said above which is what I want to know. > The more you removed, the more I can ack, untill the point only those > necessary APIs were left, such as nested EPT/NPT, heavily revisited > interrupt injection API after removing the new namespace. When you tell me which adjustments you exactly need I will do the changes w/o breaking SVM, of course. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632