All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Savoy, Pavan" <pavan_savoy@ti.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
	"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 3/3] include:linux: make ti_wilink_st like the rest
Date: Thu, 16 Sep 2010 13:59:29 -0700	[thread overview]
Message-ID: <20100916205929.GA12515@kroah.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E73940468914048@dbde02.ent.ti.com>

On Fri, Sep 17, 2010 at 01:48:53AM +0530, Savoy, Pavan wrote:
> > Also, why not just use 'u8' and friends instead?  That's the "proper"
> > kernel types to be using, not the uint8_t mess that is not correct
> > kernel types.
> 
> Yes a mistake here too.
> This should have been in the patch where I plan to combine all the headers into 1 header and have it in include/linux/
> [the headers like st_core.h, st_kim.h, st_ll.h, bt_drv.h and fm and GPs headers]
> 
> Yes, and the Bluetooth driver to go into drivers/Bluetooth/ and ST
> driver (st_core.c/st_kim.c and st_ll.c) to go into drivers/char/ And
> the upcoming FM V4L2 to go into the drivers/media/radio/
> 
> Does this sound fine?

Yes.

> > > @@ -386,6 +392,7 @@ void st_ll_wakeup(struct st_data_s *);
> > >
> > >  /**
> > >   * structures and declarations used by the st_core for FM packets
> > > + * and GPS packets
> > >   */
> > >  struct fm_event_hdr {
> > >  	unsigned char plen;
> > 
> > Oh, is it?  That should go somewhere else.
> 
> Plan is to have just 1 large header to be included by all protocol drivers (BT, FM and GPS)...
> Is it a bad idea?

No, as long as all drivers need it.

> > >  #endif /* ST_H */
> > 
> > I don't think this file is called "ST_H" here anymore.
> 
> Yes, need your input here. This file will be made use by the rest of
> the protocol drivers I plan to push patches for.
> So does ti_wilink_st.h sound fine? And in include/linux? So that rest
> of the drivers can be in their individual directories.

Yes, that name is fine, but it needs to be the same as the #ifdef
guard as well.

thanks,

greg k-h

  reply	other threads:[~2010-09-16 20:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 19:58 [PATCH] drivers:staging:ti-st: patches pavan_savoy
2010-09-10 19:58 ` [PATCH] drivers:staging:ti-st: fix kim platform device id pavan_savoy
2010-09-10 19:58   ` [RFC 1/3] drivers:staging:ti-st: mv headers to ti_wilink_st pavan_savoy
2010-09-10 19:58     ` [RFC 2/3] drivers:staging:ti-st: mv ti_wilink_st to include/ pavan_savoy
2010-09-10 19:58       ` [RFC 3/3] include:linux: make ti_wilink_st like the rest pavan_savoy
2010-09-16 20:00         ` Greg KH
2010-09-16 20:18           ` Savoy, Pavan
2010-09-16 20:59             ` Greg KH [this message]
2010-09-16 21:24               ` Savoy, Pavan
2010-09-16 19:57       ` [RFC 2/3] drivers:staging:ti-st: mv ti_wilink_st to include/ Greg KH
2010-09-16 19:56     ` [RFC 1/3] drivers:staging:ti-st: mv headers to ti_wilink_st Greg KH
2010-09-13 22:01   ` [PATCH] drivers:staging:ti-st: fix kim platform device id Savoy, Pavan
2010-09-15 21:38   ` Savoy, Pavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916205929.GA12515@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.