From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Jarkko Nikula <jhnikula@gmail.com>
Subject: Re: [RFT/PATCH 0/8] cbus patches
Date: Thu, 16 Sep 2010 17:09:00 -0700 [thread overview]
Message-ID: <20100917000900.GV29610@atomide.com> (raw)
In-Reply-To: <1284453016-8295-1-git-send-email-balbi@ti.com>
* Felipe Balbi <balbi@ti.com> [100914 01:22]:
> Hi all,
>
> if you have n8x0/n770 board getting dust, please
> spend some minutes to boot test the following
> patches on that. After you do so, please reply
> with your Tested-by tag.
>
> I'm also adding to this series Jarkko Nikula's
> ioctl fix since l-o doesn't compile without that.
Seems to kick the watchdog on N800 at least after
the following fix. So I've pushed them all into the
cbus branch for more testing :)
Regards,
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Thu, 16 Sep 2010 17:02:33 -0700
Subject: [PATCH] cbus: Fix retu init order
Device needs to be registered before the driver. Otherwise
the driver register will fail.
Eventually the device register will move to the board-*.c files.
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c
index 1397366..4a072da 100644
--- a/drivers/cbus/retu.c
+++ b/drivers/cbus/retu.c
@@ -531,11 +531,11 @@ static int __init retu_init(void)
/* Set up correct gpio number on struct resource */
retu_resource[0].start = gpio_to_irq(retu_irq_pin);
- ret = platform_driver_probe(&retu_driver, retu_probe);
+ ret = platform_device_register(&retu_device);
if (ret < 0)
goto err1;
- ret = platform_device_register(&retu_device);
+ ret = platform_driver_probe(&retu_driver, retu_probe);
if (ret < 0)
goto err2;
next prev parent reply other threads:[~2010-09-17 0:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 8:30 [RFT/PATCH 0/8] cbus patches Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 1/8] cbus: Fix compile by converting ioctl calls to unlocked_ioctl calls Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 2/8] cbus: remove device_release completion Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 3/8] cbus: retu: pass irq number via struct resource Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 4/8] cbus: retu: avoid section mismatch Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 5/8] cbus: tahvo: usb: convert to platform_driver Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 6/8] cbus: tahvo: remove device_release Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 7/8] cbus: tahvo: pass irq via struct resource Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 8/8] cbus: tahvo: avoid section mismatch Felipe Balbi
2010-09-17 0:09 ` Tony Lindgren [this message]
2010-09-17 6:44 ` [RFT/PATCH 0/8] cbus patches Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917000900.GV29610@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.