* [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1
@ 2010-09-13 21:01 Hervé Poussineau
2010-09-14 15:47 ` Edgar E. Iglesias
2010-09-17 10:52 ` Edgar E. Iglesias
0 siblings, 2 replies; 3+ messages in thread
From: Hervé Poussineau @ 2010-09-13 21:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Hervé Poussineau
Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them
This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
slirp/ip_input.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 0fe0ff7..768ab0c 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -144,7 +144,7 @@ ip_input(struct mbuf *m)
m_adj(m, ip->ip_len - m->m_len);
/* check ip_ttl for a correct ICMP reply */
- if(ip->ip_ttl==0 || ip->ip_ttl==1) {
+ if(ip->ip_ttl==0) {
icmp_error(m, ICMP_TIMXCEED,ICMP_TIMXCEED_INTRANS, 0,"ttl");
goto bad;
}
--
1.7.1.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1
2010-09-13 21:01 [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1 Hervé Poussineau
@ 2010-09-14 15:47 ` Edgar E. Iglesias
2010-09-17 10:52 ` Edgar E. Iglesias
1 sibling, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2010-09-14 15:47 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
On Mon, Sep 13, 2010 at 11:01:30PM +0200, Hervé Poussineau wrote:
> Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them
> This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> slirp/ip_input.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 0fe0ff7..768ab0c 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -144,7 +144,7 @@ ip_input(struct mbuf *m)
> m_adj(m, ip->ip_len - m->m_len);
>
> /* check ip_ttl for a correct ICMP reply */
> - if(ip->ip_ttl==0 || ip->ip_ttl==1) {
> + if(ip->ip_ttl==0) {
> icmp_error(m, ICMP_TIMXCEED,ICMP_TIMXCEED_INTRANS, 0,"ttl");
> goto bad;
> }
> --
> 1.7.1.GIT
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1
2010-09-13 21:01 [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1 Hervé Poussineau
2010-09-14 15:47 ` Edgar E. Iglesias
@ 2010-09-17 10:52 ` Edgar E. Iglesias
1 sibling, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2010-09-17 10:52 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
On Mon, Sep 13, 2010 at 11:01:30PM +0200, Hervé Poussineau wrote:
> Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them
> This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Applied, thanks.
> ---
> slirp/ip_input.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 0fe0ff7..768ab0c 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -144,7 +144,7 @@ ip_input(struct mbuf *m)
> m_adj(m, ip->ip_len - m->m_len);
>
> /* check ip_ttl for a correct ICMP reply */
> - if(ip->ip_ttl==0 || ip->ip_ttl==1) {
> + if(ip->ip_ttl==0) {
> icmp_error(m, ICMP_TIMXCEED,ICMP_TIMXCEED_INTRANS, 0,"ttl");
> goto bad;
> }
> --
> 1.7.1.GIT
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-17 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-13 21:01 [Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1 Hervé Poussineau
2010-09-14 15:47 ` Edgar E. Iglesias
2010-09-17 10:52 ` Edgar E. Iglesias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.