From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 18 Sep 2010 22:35:54 +0200
Subject: [U-Boot] [PATCH][v3] mpc8308_p1m: support for MPC8308 P1M board
In-Reply-To: <20100913201208.461501b3.kim.phillips@freescale.com>
References: <20100907164758.53dd44b9@schlenkerla.am.freescale.net>
	<1283981819-20603-1-git-send-email-yanok@emcraft.com>
	<20100913201208.461501b3.kim.phillips@freescale.com>
Message-ID: <20100918203554.F2B4D157D71@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Kim Phillips,

In message <20100913201208.461501b3.kim.phillips@freescale.com> you wrote:
>
> >  MAINTAINERS                     |    1 +
> >  board/mpc8308_p1m/Makefile      |   52 ++++
> >  board/mpc8308_p1m/config.mk     |    1 +
> >  board/mpc8308_p1m/mpc8308_p1m.c |  122 +++++++++
> >  board/mpc8308_p1m/sdram.c       |   93 +++++++
> >  boards.cfg                      |    1 +
> >  include/configs/mpc8308_p1m.h   |  548 +++++++++++++++++++++++++++++++++++++++
> 
> missing MAKEALL entry.

Not needed any more since we pick this off from boards.cfg for
"simple" boards.

> > +++ b/board/mpc8308_p1m/config.mk
> > @@ -0,0 +1 @@
> > +TEXT_BASE = 0xFC000000
> 
> ifndef TEXT_BASE
> TEXT_BASE = 0xFC000000
> endif

Why?

> > +int board_eth_init(bd_t *bis)
> > +{
> > +	int rv, num_if = 0;
> > +
> > +	/* Initialize TSECs first */
> > +	if ((rv = cpu_eth_init(bis)) >= 0)
> 
> no assignments in if statements.

Why?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never ascribe to malice that which can  adequately  be  explained  by
stupidity.