From: "J. Bruce Fields" <bfields@fieldses.org>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Neil Brown <neilb@suse.de>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 7/9] sunrpc: The per-net skeleton
Date: Mon, 20 Sep 2010 13:19:24 -0400 [thread overview]
Message-ID: <20100920171924.GM4580@fieldses.org> (raw)
In-Reply-To: <4C90BBE9.6000105@parallels.com>
On Wed, Sep 15, 2010 at 04:28:25PM +0400, Pavel Emelyanov wrote:
> @@ -38,18 +58,26 @@ init_sunrpc(void)
> err = rpcauth_init_module();
> if (err)
> goto out3;
> +
> + cache_initialize();
> +
> + err = register_pernet_subsys(&sunrpc_net_ops);
> + if (err)
> + goto out4;
> #ifdef RPC_DEBUG
> rpc_register_sysctl();
> #endif
> #ifdef CONFIG_PROC_FS
> rpc_proc_init();
> #endif
> - cache_initialize();
> cache_register(&ip_map_cache);
> cache_register(&unix_gid_cache);
> svc_init_xprt_sock(); /* svc sock transport */
> init_socket_xprt(); /* clnt sock transport */
> return 0;
> +
> +out4:
> + unregister_pernet_subsys(&sunrpc_net_ops);
If register_pernet_subsys() failed, then shouldn't this be unnecessary?
Maybe this should be rpcauth_remove_module()?
--b.
> out3:
> rpc_destroy_mempool();
> out2:
> @@ -69,6 +97,7 @@ cleanup_sunrpc(void)
> rpc_destroy_mempool();
> cache_unregister(&ip_map_cache);
> cache_unregister(&unix_gid_cache);
> + unregister_pernet_subsys(&sunrpc_net_ops);
> #ifdef RPC_DEBUG
> rpc_unregister_sysctl();
> #endif
> --
> 1.5.5.6
>
next prev parent reply other threads:[~2010-09-20 17:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 12:23 [PATCH 0/9] sunrpc: Start making sunrpc work in containers Pavel Emelyanov
2010-09-15 12:24 ` [PATCH 1/9] sunrpc: Pass the ip_map_parse's cd to lower calls Pavel Emelyanov
2010-09-15 12:25 ` [PATCH 2/9] sunrpc: Make xprt auth cache release work with the xprt Pavel Emelyanov
2010-09-15 12:25 ` [PATCH 3/9] sunrpc: Pass xprt to cached get/put routines Pavel Emelyanov
2010-09-15 12:26 ` [PATCH 4/9] sunrpc: Add net to pure API calls Pavel Emelyanov
2010-09-15 12:27 ` [PATCH 5/9] sunrpc: Add routines that allow registering per-net caches Pavel Emelyanov
2010-09-15 12:27 ` [PATCH 6/9] sunrpc: Tag svc_xprt with net Pavel Emelyanov
2010-09-15 12:28 ` [PATCH 7/9] sunrpc: The per-net skeleton Pavel Emelyanov
2010-09-20 17:19 ` J. Bruce Fields [this message]
2010-09-20 18:54 ` Pavel Emelyanov
2010-09-15 12:28 ` [PATCH 8/9] sunrpc: Make the /proc/net/rpc appear in net namespaces Pavel Emelyanov
2010-09-15 12:29 ` [PATCH 9/9] sunrpc: Make the ip_map_cache be per-net Pavel Emelyanov
2010-09-15 15:31 ` [PATCH 0/9] sunrpc: Start making sunrpc work in containers Boaz Harrosh
2010-09-15 16:05 ` Pavel Emelyanov
2010-09-20 16:13 ` J. Bruce Fields
2010-09-20 16:33 ` Pavel Emelyanov
2010-09-20 18:04 ` J. Bruce Fields
2010-09-20 19:13 ` Pavel Emelyanov
2010-09-20 19:28 ` Chuck Lever
2010-09-20 19:56 ` J. Bruce Fields
2010-09-20 20:13 ` Trond Myklebust
2010-09-20 20:35 ` Chuck Lever
2010-09-20 21:37 ` Trond Myklebust
2010-09-20 20:05 ` Trond Myklebust
2010-09-20 20:09 ` J. Bruce Fields
2010-09-20 21:36 ` Trond Myklebust
[not found] ` <1285018566.2851.159.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-09-20 21:43 ` J. Bruce Fields
2010-09-21 7:11 ` Pavel Emelyanov
2010-09-21 12:18 ` Trond Myklebust
2010-09-21 12:31 ` Pavel Emelyanov
2010-10-08 17:06 ` Trond Myklebust
2010-09-27 9:56 [PATCH v2 0/9] sunrpc: Virtualize ip_map_cache Pavel Emelyanov
2010-09-27 10:01 ` [PATCH 7/9] sunrpc: The per-net skeleton Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920171924.GM4580@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.