From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] usb: omap: ohci: Missing driver unregister in module exit Date: Tue, 21 Sep 2010 13:43:58 -0700 Message-ID: <20100921204358.GF25112@kroah.com> References: <1284419401-32101-1-git-send-email-keshava_mgowda@ti.com> <0680EC522D0CC943BC586913CF3768C003C210F6A6@dbde02.ent.ti.com> <20100917064316.GF23325@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kroah.org ([198.145.64.141]:39887 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755609Ab0IUUrs (ORCPT ); Tue, 21 Sep 2010 16:47:48 -0400 Content-Disposition: inline In-Reply-To: <20100917064316.GF23325@legolas.emea.dhcp.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: "Munegowda, Keshava" , "linux-usb-owner@vger.kernel.org" , "Gadiyar, Anand" , "Kamat, Nishant" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" On Fri, Sep 17, 2010 at 09:43:16AM +0300, Felipe Balbi wrote: > On Thu, Sep 16, 2010 at 06:39:20AM -0500, Munegowda, Keshava wrote: > >>-----Original Message----- > >>From: Munegowda, Keshava > >>Sent: Tuesday, September 14, 2010 4:40 AM > >>To: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org > >>Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava > >>Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit > >> > >>The un-registration of OHCI driver was not done in > >>the ohci_hcd_mod_exit function. This was affecting rmmod command not > >>to work for OMAP3 platforms. > >>The platform driver un-registration for OMAP3 platforms is perfomed > >>while removing the OHCI module from kernel. > >> > >>Signed-off-by: Keshava Munegowda > >>--- > >> drivers/usb/host/ohci-hcd.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >>Index: linux-2.6/drivers/usb/host/ohci-hcd.c > >>=================================================================== > >>--- linux-2.6.orig/drivers/usb/host/ohci-hcd.c > >>+++ linux-2.6/drivers/usb/host/ohci-hcd.c > >>@@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi > >> #ifdef PLATFORM_DRIVER > >> platform_driver_unregister(&PLATFORM_DRIVER); > >> #endif > >>+#ifdef OMAP3_PLATFORM_DRIVER > >>+ platform_driver_unregister(&OMAP3_PLATFORM_DRIVER); > >>+#endif > >> #ifdef PS3_SYSTEM_BUS_DRIVER > >> ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER); > >> #endif > > > >Hi Greg, > > Do you any comments on this patch? > > my missing S-O-B, maybe. Here it goes: > > Signed-of-by: Felipe Balbi Yup, all good now. thanks, greg k-h