All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Tony Lindgren <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"Discussion of the Amstrad E3 emailer hardware/software"
	<e3-hacking@earth.li>
Subject: Re: [RESEND][PATCH v2 2/6] OMAP1: Add support for SoC camera interface
Date: Fri, 24 Sep 2010 12:28:24 +0200	[thread overview]
Message-ID: <201009241228.26466.jkrzyszt@tis.icnet.pl> (raw)
In-Reply-To: <Pine.LNX.4.64.1009240853080.14966@axis700.grange>

Friday 24 September 2010 08:54:20 Guennadi Liakhovetski napisał(a):
> On Thu, 23 Sep 2010, Tony Lindgren wrote:
> > * Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [100923 16:37]:
> > > Friday 24 September 2010 01:23:10 Tony Lindgren napisał(a):
> > > > I think you can just move the OMAP1_CAMERA_IOSIZE to the devices.c or
> > > > someplace like that?
> > >
> > > Tony,
> > > Not exactly. I use the OMAP1_CAMERA_IOSIZE inside the driver when
> > > reserving space for register cache.
> > >
> > > I think that I could just duplicate its definition in the devices.c for
> > > now, than clean things up with a folloup patch when both parts already
> > > get merged. Would this be acceptable?
> >
> > Yeah, that sounds good to me.
>
> ...better yet put a zero-length cache array at the end of your struct
> omap1_cam_dev and allocate it dynamically, calculated from the resource
> size.

Guennadi,
Yes, this seems the best solution, thank you.

Tony,
You'll soon get it as you ask: <media/camera.h> no longer included from 
<mach/camera.h>.

Thanks,
Janusz

  reply	other threads:[~2010-09-24 10:29 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-11  1:17 [PATCH v2 0/6] Add camera support to the OMAP1 Amstrad Delta videophone Janusz Krzysztofik
2010-09-11  1:21 ` [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface Janusz Krzysztofik
2010-09-11  9:32   ` Janusz Krzysztofik
2010-09-21 23:23   ` Guennadi Liakhovetski
2010-09-22  0:10     ` hermann pitton
2010-09-22  6:08       ` Guennadi Liakhovetski
2010-09-22 23:31         ` hermann pitton
2010-09-22 18:13     ` Janusz Krzysztofik
2010-09-22 18:13       ` Janusz Krzysztofik
2010-09-23 13:33       ` Guennadi Liakhovetski
2010-09-23 13:33         ` Guennadi Liakhovetski
2010-09-23 14:51         ` Janusz Krzysztofik
2010-09-23 14:51           ` Janusz Krzysztofik
2010-09-23 16:10           ` Guennadi Liakhovetski
2010-09-23 16:10             ` Guennadi Liakhovetski
2010-09-11  1:23 ` [PATCH v2 2/6] OMAP1: Add support for SoC " Janusz Krzysztofik
2010-09-11  1:34   ` [RESEND][PATCH " Janusz Krzysztofik
2010-09-23 23:23     ` Tony Lindgren
2010-09-23 23:44       ` Janusz Krzysztofik
2010-09-23 23:44         ` Janusz Krzysztofik
2010-09-23 23:54         ` Tony Lindgren
2010-09-23 23:54           ` Tony Lindgren
2010-09-24  6:54           ` Guennadi Liakhovetski
2010-09-24 10:28             ` Janusz Krzysztofik [this message]
2010-09-24 17:43               ` Tony Lindgren
2010-09-22  6:53   ` [PATCH " Guennadi Liakhovetski
2010-09-22 18:20     ` Janusz Krzysztofik
2010-09-22 18:20       ` Janusz Krzysztofik
2010-09-11  1:25 ` [PATCH v2 3/6] SoC Camera: add driver for OV6650 sensor Janusz Krzysztofik
2010-09-22  9:12   ` Guennadi Liakhovetski
2010-09-22 18:23     ` Janusz Krzysztofik
2010-09-23 16:06       ` Guennadi Liakhovetski
2010-09-23 22:45         ` Janusz Krzysztofik
2010-09-24  6:52           ` Guennadi Liakhovetski
2010-09-24 11:36             ` Janusz Krzysztofik
2010-09-24 11:51               ` Guennadi Liakhovetski
2010-09-11  1:26 ` [PATCH v2 4/6] SoC Camera: add support for g_parm / s_parm operations Janusz Krzysztofik
2010-09-11  1:27 ` [PATCH v2 5/6] OMAP1: Amstrad Delta: add support for camera Janusz Krzysztofik
2010-09-23 23:14   ` Tony Lindgren
2010-09-23 23:26     ` Tony Lindgren
2010-09-24  0:00       ` Janusz Krzysztofik
2010-09-24  0:00         ` Janusz Krzysztofik
2010-09-24  0:49         ` Tony Lindgren
2010-09-24  6:57           ` Guennadi Liakhovetski
2010-09-24  6:57             ` Guennadi Liakhovetski
2010-09-24 11:08             ` Janusz Krzysztofik
2010-09-24 11:08               ` Janusz Krzysztofik
2010-09-11  1:28 ` [PATCH v2 6/6] OMAP1: Amstrad Delta: add camera controlled LEDS trigger Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009241228.26466.jkrzyszt@tis.icnet.pl \
    --to=jkrzyszt@tis.icnet.pl \
    --cc=e3-hacking@earth.li \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.