From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757093Ab0IYAfG (ORCPT ); Fri, 24 Sep 2010 20:35:06 -0400 Received: from cantor.suse.de ([195.135.220.2]:33837 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754685Ab0IYAfD (ORCPT ); Fri, 24 Sep 2010 20:35:03 -0400 Date: Fri, 24 Sep 2010 17:33:08 -0700 From: Greg KH To: "Eric W. Biederman" Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 0/5] uio hotplug support Message-ID: <20100925003308.GA29910@suse.de> References: <20100917205946.GF2522@local> <20100924104555.GC1819@silverbox.local> <20100924173106.GA4966@silverbox.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2010 at 05:05:17PM -0700, Eric W. Biederman wrote: > "Hans J. Koch" writes: > > > On Fri, Sep 24, 2010 at 10:14:11AM -0700, Eric W. Biederman wrote: > >> "Hans J. Koch" writes: > >> > >> > On Mon, Sep 20, 2010 at 12:19:59AM -0700, Eric W. Biederman wrote: > >> >> > >> >> Implement the ability to hotunplug a uio device while file handles > >> >> are still open without crashing. > >> > > >> > Could you please create patches that apply on top of your already > >> > accepted UIO changes? > >> > >> That is what the patches I sent should be. My apologies if I had not > >> made that clear. Certainly these patches were built against my previous > >> changes, on top of 2.6.36-rc4. Are you having problems? > > > > Hmm, I applied your first series of 5 patches (which I signed-off). When > > trying to apply your second series, I get this from quilt: > > > > Applying patch 2_1-Simplify-the-lifetime-logic-of-struct-uio_device.patch > > patching file drivers/uio/uio.c > > Hunk #2 succeeded at 287 (offset 8 lines). > > Hunk #3 succeeded at 312 (offset 8 lines). > > Hunk #4 FAILED at 339. > > Hunk #5 succeeded at 806 (offset 17 lines). > > Hunk #6 FAILED at 831. > > Hunk #7 FAILED at 858. > > Hunk #8 FAILED at 889. > > 4 out of 8 hunks FAILED -- rejects in file drivers/uio/uio.c > > Patch 2_1-Simplify-the-lifetime-logic-of-struct-uio_device.patch does not apply (enforce with -f) > > > > The first series applied without any fuzz against 2.6.36-rc5. > > I am stumped. Do you perhaps have some local uio changes? > > Using 2.6.36-rc5 as a base I tried it twice. Once by taking my patches > that I sent, and again by saving my email and then applying the changes. > > Both times the changes applied cleanly. No offsets, and no fuzz. At > least that is what git-am said. > > Should I perhaps make a git branch you could pull? Try it on linux-next, as I've applied your previous patches there already. thanks, greg k-h