From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933368Ab0I0Son (ORCPT ); Mon, 27 Sep 2010 14:44:43 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:45449 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933202Ab0I0Sol (ORCPT ); Mon, 27 Sep 2010 14:44:41 -0400 Date: Mon, 27 Sep 2010 14:44:46 -0400 From: "John W. Linville" To: Ohad Ben-Cohen Cc: David Miller , sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (net tree related) Message-ID: <20100927184445.GF11086@tuxdriver.com> References: <20100927154408.55a28127.sfr@canb.auug.org.au> <20100927180412.GD11086@tuxdriver.com> <20100927.111818.149846920.davem@davemloft.net> <20100927182546.GE11086@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2010 at 08:38:50PM +0200, Ohad Ben-Cohen wrote: > On Mon, Sep 27, 2010 at 8:25 PM, John W. Linville > wrote: > >> BTW, if this fuglet going to work if the driver is built modular? > >> > >> The idea of this things seems to be to allow arch platform code to call > >> into it to set things.  Such calls from arch platform code are going > >> to be "obj-y" > >> > >> So if this is built into the modular driver, I can't see how it > >> can work. > > > > Dave is right -- these Kconfig dependencies (or lack thereof) seem > > to be wrong. > > This is why I had to put it in drivers/net/wireless/Makefile (in both > the original patch and in the fix I sent earlier) and not in > drivers/net/wireless/wl12xx/Makefile (as it was in the fix that Dave > was referring to). > > This way it works with a modular driver. That doesn't seem very helpful if someone selects CONFIG_MACH_OMAP_ZOOM2=y CONFIG_WL12XX_PLATFORM_DATA=n or am I missing something? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.