From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760600Ab0I1CwL (ORCPT ); Mon, 27 Sep 2010 22:52:11 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:49348 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757964Ab0I1CwK (ORCPT ); Mon, 27 Sep 2010 22:52:10 -0400 Date: Tue, 28 Sep 2010 03:52:02 +0100 From: Matthew Garrett To: =?iso-8859-1?Q?Keng-Y=FC?= Lin Cc: len.brown@intel.com, alan-jenkins@tuffmail.co.uk, superm1@ubuntu.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] dell-laptop: Add debugfs support Message-ID: <20100928025202.GA17740@srcf.ucam.org> References: <1284702459-31646-1-git-send-email-keng-yu.lin@canonical.com> <1285325323-4528-1-git-send-email-keng-yu.lin@canonical.com> <20100927140028.GB856@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2010 at 10:43:44AM +0800, Keng-Yü Lin wrote: > On Mon, Sep 27, 2010 at 10:00 PM, Matthew Garrett wrote: > > What's the difference between this version and v3? > > > > -- > > Matthew Garrett | mjg59@srcf.ucam.org > > > > Hi Mathew: > V3 does not print the correct bit of hwswitch_state. I just found > that V4 messed up by the operator precedence; will send a new fix. Ok, no problem. In future it's helpful to include a changelog with the difference - see Documentation/SubmittingPatches section 15 for some information on that. I'll wait for v5 and then merge it. -- Matthew Garrett | mjg59@srcf.ucam.org