From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310Ab0I2GaE (ORCPT ); Wed, 29 Sep 2010 02:30:04 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:53451 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752980Ab0I2GaC (ORCPT ); Wed, 29 Sep 2010 02:30:02 -0400 Date: Wed, 29 Sep 2010 15:29:58 +0900 From: Grant Likely To: Michal Simek Cc: linux-kernel@vger.kernel.org, john.williams@petalogix.com, edgar.iglesias@gmail.com, duyl@xilinx.com, linnj@xilinx.com, microblaze-uclinux@itee.uq.edu.au, David Woodhouse , Tejun Heo , linux-mtd@lists.infradead.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH 2/7] of: MTD: Fix OF probing on little-endian systems Message-ID: <20100929062958.GE2439@angua.secretlab.ca> References: <1285739538-29058-1-git-send-email-monstr@monstr.eu> <1285739538-29058-2-git-send-email-monstr@monstr.eu> <1285739538-29058-3-git-send-email-monstr@monstr.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1285739538-29058-3-git-send-email-monstr@monstr.eu> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2010 at 03:52:13PM +1000, Michal Simek wrote: > Convert big-endian DTB to little-endian if necessary. > > Signed-off-by: Michal Simek > CC: David Woodhouse > CC: Tejun Heo > CC: Grant Likely > CC: linux-mtd@lists.infradead.org > CC: linux-kernel@vger.kernel.org > CC: devicetree-discuss@lists.ozlabs.org Applied, thanks. g. > --- > drivers/mtd/maps/physmap_of.c | 2 +- > drivers/mtd/ofpart.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c > index fe63f6b..ec3edf6 100644 > --- a/drivers/mtd/maps/physmap_of.c > +++ b/drivers/mtd/maps/physmap_of.c > @@ -294,7 +294,7 @@ static int __devinit of_flash_probe(struct platform_device *dev, > info->list[i].map.name = dev_name(&dev->dev); > info->list[i].map.phys = res.start; > info->list[i].map.size = res_size; > - info->list[i].map.bankwidth = *width; > + info->list[i].map.bankwidth = be32_to_cpup(width); > > err = -ENOMEM; > info->list[i].map.virt = ioremap(info->list[i].map.phys, > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index 8bf7dc6..7bd171e 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -53,8 +53,8 @@ int __devinit of_mtd_parse_partitions(struct device *dev, > continue; > } > > - (*pparts)[i].offset = reg[0]; > - (*pparts)[i].size = reg[1]; > + (*pparts)[i].offset = be32_to_cpu(reg[0]); > + (*pparts)[i].size = be32_to_cpu(reg[1]); > > partname = of_get_property(pp, "label", &len); > if (!partname) > -- > 1.5.5.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 2/7] of: MTD: Fix OF probing on little-endian systems Date: Wed, 29 Sep 2010 15:29:58 +0900 Message-ID: <20100929062958.GE2439@angua.secretlab.ca> References: <1285739538-29058-1-git-send-email-monstr@monstr.eu> <1285739538-29058-2-git-send-email-monstr@monstr.eu> <1285739538-29058-3-git-send-email-monstr@monstr.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1285739538-29058-3-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Michal Simek Cc: microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, duyl-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, linnj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, edgar.iglesias-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, David Woodhouse , john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Sep 29, 2010 at 03:52:13PM +1000, Michal Simek wrote: > Convert big-endian DTB to little-endian if necessary. > > Signed-off-by: Michal Simek > CC: David Woodhouse > CC: Tejun Heo > CC: Grant Likely > CC: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > CC: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Applied, thanks. g. > --- > drivers/mtd/maps/physmap_of.c | 2 +- > drivers/mtd/ofpart.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c > index fe63f6b..ec3edf6 100644 > --- a/drivers/mtd/maps/physmap_of.c > +++ b/drivers/mtd/maps/physmap_of.c > @@ -294,7 +294,7 @@ static int __devinit of_flash_probe(struct platform_device *dev, > info->list[i].map.name = dev_name(&dev->dev); > info->list[i].map.phys = res.start; > info->list[i].map.size = res_size; > - info->list[i].map.bankwidth = *width; > + info->list[i].map.bankwidth = be32_to_cpup(width); > > err = -ENOMEM; > info->list[i].map.virt = ioremap(info->list[i].map.phys, > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index 8bf7dc6..7bd171e 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -53,8 +53,8 @@ int __devinit of_mtd_parse_partitions(struct device *dev, > continue; > } > > - (*pparts)[i].offset = reg[0]; > - (*pparts)[i].size = reg[1]; > + (*pparts)[i].offset = be32_to_cpu(reg[0]); > + (*pparts)[i].size = be32_to_cpu(reg[1]); > > partname = of_get_property(pp, "label", &len); > if (!partname) > -- > 1.5.5.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pw0-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P0qB1-00016V-Sn for linux-mtd@lists.infradead.org; Wed, 29 Sep 2010 06:30:04 +0000 Received: by pwi5 with SMTP id 5so139581pwi.36 for ; Tue, 28 Sep 2010 23:30:02 -0700 (PDT) Sender: Grant Likely Date: Wed, 29 Sep 2010 15:29:58 +0900 From: Grant Likely To: Michal Simek Subject: Re: [PATCH 2/7] of: MTD: Fix OF probing on little-endian systems Message-ID: <20100929062958.GE2439@angua.secretlab.ca> References: <1285739538-29058-1-git-send-email-monstr@monstr.eu> <1285739538-29058-2-git-send-email-monstr@monstr.eu> <1285739538-29058-3-git-send-email-monstr@monstr.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1285739538-29058-3-git-send-email-monstr@monstr.eu> Cc: microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Tejun Heo , linux-mtd@lists.infradead.org, duyl@xilinx.com, linnj@xilinx.com, edgar.iglesias@gmail.com, David Woodhouse , john.williams@petalogix.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 29, 2010 at 03:52:13PM +1000, Michal Simek wrote: > Convert big-endian DTB to little-endian if necessary. > > Signed-off-by: Michal Simek > CC: David Woodhouse > CC: Tejun Heo > CC: Grant Likely > CC: linux-mtd@lists.infradead.org > CC: linux-kernel@vger.kernel.org > CC: devicetree-discuss@lists.ozlabs.org Applied, thanks. g. > --- > drivers/mtd/maps/physmap_of.c | 2 +- > drivers/mtd/ofpart.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c > index fe63f6b..ec3edf6 100644 > --- a/drivers/mtd/maps/physmap_of.c > +++ b/drivers/mtd/maps/physmap_of.c > @@ -294,7 +294,7 @@ static int __devinit of_flash_probe(struct platform_device *dev, > info->list[i].map.name = dev_name(&dev->dev); > info->list[i].map.phys = res.start; > info->list[i].map.size = res_size; > - info->list[i].map.bankwidth = *width; > + info->list[i].map.bankwidth = be32_to_cpup(width); > > err = -ENOMEM; > info->list[i].map.virt = ioremap(info->list[i].map.phys, > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index 8bf7dc6..7bd171e 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -53,8 +53,8 @@ int __devinit of_mtd_parse_partitions(struct device *dev, > continue; > } > > - (*pparts)[i].offset = reg[0]; > - (*pparts)[i].size = reg[1]; > + (*pparts)[i].offset = be32_to_cpu(reg[0]); > + (*pparts)[i].size = be32_to_cpu(reg[1]); > > partname = of_get_property(pp, "label", &len); > if (!partname) > -- > 1.5.5.1 >