From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754425Ab0JETVL (ORCPT ); Tue, 5 Oct 2010 15:21:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844Ab0JETVK (ORCPT ); Tue, 5 Oct 2010 15:21:10 -0400 Date: Tue, 5 Oct 2010 21:18:37 +0200 From: Andrea Arcangeli To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov Subject: Re: Transparent Hugepage Support #30 Message-ID: <20101005191837.GY26357@random.random> References: <20100901190859.GA20316@random.random> <20101004032451.GA11622@spritzera.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101004032451.GA11622@spritzera.linux.bs1.fc.nec.co.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naoya, On Mon, Oct 04, 2010 at 12:24:51PM +0900, Naoya Horiguchi wrote: > Hi, > > I experienced build error of "calling pte_alloc_map() with 3 parameters, > while it's defined to have 4 parameters" in arch/x86/kernel/tboot.c etc. > Is the following chunk in patch "pte alloc trans splitting" necessary? > > @@ -1167,16 +1168,18 @@ static inline void pgtable_page_dtor(struct page *page) > pte_unmap(pte); \ > } while (0) > > -#define pte_alloc_map(mm, pmd, address) \ > - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ > - NULL: pte_offset_map(pmd, address)) > +#define pte_alloc_map(mm, vma, pmd, address) \ > + ((unlikely(pmd_none(*(pmd))) && __pte_alloc(mm, vma, \ > + pmd, address))? \ > + NULL: pte_offset_map(pmd, address)) Sure it's necessary. Can you try again with current aa.git origin/master? (84c5ce35cf221ed0e561dec279df6985a388a080) Thanks a lot. Andrea From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id B785B6B0085 for ; Tue, 5 Oct 2010 15:20:09 -0400 (EDT) Date: Tue, 5 Oct 2010 21:18:37 +0200 From: Andrea Arcangeli Subject: Re: Transparent Hugepage Support #30 Message-ID: <20101005191837.GY26357@random.random> References: <20100901190859.GA20316@random.random> <20101004032451.GA11622@spritzera.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101004032451.GA11622@spritzera.linux.bs1.fc.nec.co.jp> Sender: owner-linux-mm@kvack.org To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Chris Mason , Borislav Petkov List-ID: Hi Naoya, On Mon, Oct 04, 2010 at 12:24:51PM +0900, Naoya Horiguchi wrote: > Hi, > > I experienced build error of "calling pte_alloc_map() with 3 parameters, > while it's defined to have 4 parameters" in arch/x86/kernel/tboot.c etc. > Is the following chunk in patch "pte alloc trans splitting" necessary? > > @@ -1167,16 +1168,18 @@ static inline void pgtable_page_dtor(struct page *page) > pte_unmap(pte); \ > } while (0) > > -#define pte_alloc_map(mm, pmd, address) \ > - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ > - NULL: pte_offset_map(pmd, address)) > +#define pte_alloc_map(mm, vma, pmd, address) \ > + ((unlikely(pmd_none(*(pmd))) && __pte_alloc(mm, vma, \ > + pmd, address))? \ > + NULL: pte_offset_map(pmd, address)) Sure it's necessary. Can you try again with current aa.git origin/master? (84c5ce35cf221ed0e561dec279df6985a388a080) Thanks a lot. Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org