From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Tue, 12 Oct 2010 23:27:08 +0200
Subject: [U-Boot] [PATCH v2 4/6] boot: change some arch ifdefs to
	feature ifdefs
In-Reply-To: <1285775292-15060-5-git-send-email-john.rigby@linaro.org>
References: <1285775292-15060-1-git-send-email-john.rigby@linaro.org>
	<1285775292-15060-5-git-send-email-john.rigby@linaro.org>
Message-ID: <20101012212708.5C17914F310@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear John Rigby,

In message <1285775292-15060-5-git-send-email-john.rigby@linaro.org> you wrote:
> The routines boot_ramdisk_high, boot_get_cmdline and boot_get_kbd
> are currently enabled by various combinations of CONFIG_M68K,
> CONFIG_POWERPC and CONFIG_SPARC.
> 
> Use CONFIG_<FEATURE> defines instead.
> 
> CONFIG_BOOT_RAMDISK_HIGH
> CONFIG_BOOT_GET_CMDLINE
> CONFIG_BOOT_GET_KBD
> 
> Define these as appropriate in arch/include/asm/config.h files.

No. CONFIG_ means user coinfigurable options; these are not actually
configurable on a per-board base by the end user, so CONFIG_SYS_
should be used.

> Signed-off-by: John Rigby <john.rigby@linaro.org>
> ---
>  arch/m68k/include/asm/config.h    |    3 +++
>  arch/powerpc/include/asm/config.h |    3 +++
>  arch/sparc/include/asm/config.h   |    1 +
>  common/cmd_bootm.c                |    2 +-
>  common/image.c                    |   10 ++++++----
>  include/image.h                   |    9 ++++++---
>  6 files changed, 20 insertions(+), 8 deletions(-)

Also, the new variables need to be documented in the README.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He's dead, Jim
	-- McCoy, "The Devil in the Dark", stardate 3196.1