Re: [PATCH] xl create: endless loop

[Christoph Egger <Christoph.Egger@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Monday 18 October 2010 14:50:35 Christoph Egger wrote:
> Hi!
>
> I cannot start a guest with 'xl create' due to an endless loop in libxl.c,
> function libxl__get_free_memory_slack():
>
> There is this code snippet:
>
> retry:
>     free_mem_slack_s = libxl__xs_read(gc, XBT_NULL, free_mem_slack_path);
>     if (!free_mem_slack_s) {
>         rc = libxl__fill_dom0_memory_info(gc, &target_memkb);
>         if (rc < 0)
>             return rc;
>         goto retry;
>     } else {
>
>
> libxl__xs_read() returns 0 and libxl__fill_dom0_memory_info() also returns
> 0. So there's a loop of retries.

Attached patch fixes the endless loop.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_xl.diff --]
[-- Type: text/x-diff, Size: 454 bytes --]

diff -r 9d8d6b93114e tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Mon Oct 18 15:24:39 2010 +0200
+++ b/tools/libxl/libxl.c	Tue Oct 19 10:29:00 2010 +0200
@@ -2836,7 +2836,7 @@ retry:
     free_mem_slack_s = libxl__xs_read(gc, XBT_NULL, free_mem_slack_path);
     if (!free_mem_slack_s) {
         rc = libxl__fill_dom0_memory_info(gc, &target_memkb);
-        if (rc < 0)
+        if (rc <= 0)
             return rc;
         goto retry;
     } else {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel