All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jiri Slaby <jirislaby@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: audit_tree: sleep inside atomic
Date: Sat, 30 Oct 2010 07:21:47 +0100	[thread overview]
Message-ID: <20101030062147.GA16697@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1284581305.2703.127.camel@localhost.localdomain>

On Wed, Sep 15, 2010 at 04:08:25PM -0400, Eric Paris wrote:
> On Mon, 2010-09-13 at 17:05 -0700, Andrew Morton wrote:
> > On Fri, 03 Sep 2010 15:52:30 +0200
> > Jiri Slaby <jirislaby@gmail.com> wrote:
> > 
> > > Ideas, comments?
> > 
> > Apparently not.
> 
> Sorry, I've been slacking off on vacation the last couple weeks.
> 
> > The question is: why is nobody reporting this bug?  Obviously nobody's
> > running that code path.  Why not?
> 
> The only people who run this code path, that I know of, are govt orgs
> who run in certified environments.  I don't know of any upstream kernel
> users who really would hit it.
> 
> In any case I don't think it would be particularly painful to just
> always allocate a chunk between the two locks.  this is not a hot path
> by any stretch of the imagination.  I'll see if I can't code something
> up today/tomorrow.

It's not even a matter of path being hot; we should do allocation before
grabbing entry->lock if size is non-zero.  End of the story.

Fixed in audit branch I'll push today.

      reply	other threads:[~2010-10-30  6:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 15:15 audit_tree: sleep inside atomic Jiri Slaby
2010-09-03 13:52 ` Jiri Slaby
2010-09-14  0:05   ` Andrew Morton
2010-09-15 20:08     ` Eric Paris
2010-10-30  6:21       ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101030062147.GA16697@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=eparis@redhat.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.