From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 31 Oct 2010 10:28:29 +0100 Subject: [U-Boot] Are typedefs discouraged? In-Reply-To: <4CCD305D.50600@emk-elektronik.de> References: <4CCD305D.50600@emk-elektronik.de> Message-ID: <20101031092829.0F6871522C0@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Reinhard Meyer, In message <4CCD305D.50600@emk-elektronik.de> you wrote: > Hi All, > > WARNING: do not add new typedefs > #64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19: > +typedef struct at91_shdwn { > > total: 0 errors, 1 warnings, 45 lines checked > > xx has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > I assume that "rule" does not apply to u-boot, and such warnings > can be ignored? No. > However why would typedefs be discouraged in kernel? Please read "Chapter 5: Typedefs" in the "CodingStyle" document. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There's a way out of any cage. -- Captain Christopher Pike, "The Menagerie" ("The Cage"), stardate unknown.