From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235Ab0KAUBc (ORCPT ); Mon, 1 Nov 2010 16:01:32 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:51269 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693Ab0KAUBa (ORCPT ); Mon, 1 Nov 2010 16:01:30 -0400 Date: Mon, 1 Nov 2010 16:01:22 -0400 From: Johannes Weiner To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Balbir Singh , Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101101200122.GH840@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote: > Hi (please CC me on replies), > > > Apologies to those who receive this multiple times. I screwed up the To: > field in my original mail :-( > > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then > followed by memset() to zero the memory. This can be more efficiently > achieved by using kzalloc() and vzalloc(). > > > Signed-off-by: Jesper Juhl Looks good to me, but there is also the memset after kmalloc in alloc_mem_cgroup_per_zone_info(). Can you switch that over as well in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 680B48D0030 for ; Mon, 1 Nov 2010 16:01:35 -0400 (EDT) Date: Mon, 1 Nov 2010 16:01:22 -0400 From: Johannes Weiner Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101101200122.GH840@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Balbir Singh , Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org List-ID: On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote: > Hi (please CC me on replies), > > > Apologies to those who receive this multiple times. I screwed up the To: > field in my original mail :-( > > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then > followed by memset() to zero the memory. This can be more efficiently > achieved by using kzalloc() and vzalloc(). > > > Signed-off-by: Jesper Juhl Looks good to me, but there is also the memset after kmalloc in alloc_mem_cgroup_per_zone_info(). Can you switch that over as well in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org